hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 04:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: Modernise and false positive in py/undefined-export.

Browse Source
This commit is contained in:
Taus Brock-Nannestad
2019-10-21 16:07:48 +02:00
parent 37291c5642
commit 8a1d1e7b7a
3 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
python/ql/src/Variables/UndefinedExport.ql
View File

@@ -22,10 +22,10 @@ predicate declaredInAll(Module m, StrConst name)
)
}
predicate mutates_globals(PythonModuleObject m) {
predicate mutates_globals(ModuleValue m) {
exists(CallNode globals |
globals = Object::builtin("globals").(FunctionObject).getACall() and
globals.getScope() = m.getModule() |
globals.getScope() = m.getScope() |
exists(AttrNode attr | attr.getObject() = globals)
or
exists(SubscriptNode sub | sub.getValue() = globals and sub.isStore())
@@ -34,7 +34,7 @@ predicate mutates_globals(PythonModuleObject m) {
exists(Object enum_convert |
enum_convert.hasLongName("enum.Enum._convert") and
exists(CallNode call |
call.getScope() = m.getModule()
call.getScope() = m.getScope()
|
enum_convert.(FunctionObject).getACall() = call or
call.getFunction().refersTo(enum_convert)
@@ -42,11 +42,11 @@ predicate mutates_globals(PythonModuleObject m) {
)
}
from PythonModuleObject m, StrConst name, string exported_name
where declaredInAll(m.getModule(), name) and
from ModuleValue m, StrConst name, string exported_name
where declaredInAll(m.getScope(), name) and
exported_name = name.strValue() and
not m.hasAttribute(exported_name) and
not (m.getShortName() = "__init__" and exists(m.getPackage().getModule().getSubModule(exported_name))) and
not exists(ImportStarNode imp | imp.getEnclosingModule() = m.getModule() | not imp.getModule().refersTo(_)) and
not (m.getScope().getShortName() = "__init__" and exists(m.getScope().getPackage().getSubModule(exported_name))) and
not exists(ImportStarNode imp | imp.getEnclosingModule() = m.getScope() | imp.getModule().pointsTo().isAbsent()) and
not mutates_globals(m)
select name, "The name '" + exported_name + "' is exported by __all__ but is not defined."