From 89be8d87107beb1d1b4e8d24485f30f5e9720a17 Mon Sep 17 00:00:00 2001 From: Alex Ford Date: Thu, 13 May 2021 12:59:16 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Arthur Baars --- ql/src/queries/security/cwe-732/WeakFilePermissions.ql | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ql/src/queries/security/cwe-732/WeakFilePermissions.ql b/ql/src/queries/security/cwe-732/WeakFilePermissions.ql index 79fd3f8b663..d75aa6831e7 100644 --- a/ql/src/queries/security/cwe-732/WeakFilePermissions.ql +++ b/ql/src/queries/security/cwe-732/WeakFilePermissions.ql @@ -52,8 +52,8 @@ class PermissivePermissionsExpr extends Expr { (acc = access(world_permission(perm)) or acc = access(group_permission(perm))) ) or - // adding/setting read or write permissions for all/group/owner - this.(StringLiteral).getValueText().regexpMatch(".*[ago][^-=+]*[+=]*[xXst]*[rw].*") + // adding/setting read or write permissions for all/group/other + this.(StringLiteral).getValueText().regexpMatch(".*[ago][^-=+]*[+=][xXst]*[rw].*") } }