hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4523 from erik-krogh/optionalPromise

Browse Source 
Approved by asgerf
This commit is contained in:
CodeQL CI
2020-10-21 00:34:12 -07:00
committed by GitHub
parent 996488511c bdbc8f5c91
commit 897d8de65a
3 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
javascript/ql/src/Expressions/MissingAwait.ql
View File

@@ -13,20 +13,20 @@ import javascript
/**
* Holds if `call` is a call to an `async` function.
*/
predicate isAsyncCall(DataFlow::CallNode call) {
predicate isAsyncCall(DataFlow::CallNode call, boolean nullable) {
// If a callee is known, and all known callees are async, assume all
// possible callees are async.
forex(Function callee | call.getACallee() = callee | callee.isAsync())
forex(Function callee | call.getACallee() = callee | callee.isAsync()) and
if call.asExpr() instanceof OptionalUse then nullable = true else nullable = false
}
/**
* Holds if `node` is always a promise.
*/
predicate isPromise(DataFlow::SourceNode node, boolean nullable) {
isAsyncCall(node) and
nullable = false
isAsyncCall(node, nullable)
or
not isAsyncCall(node) and
not isAsyncCall(node, _) and
node.asExpr().getType() instanceof PromiseType and
nullable = true
}