hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

CPP: Improve the logic in ArithmeticWithExtremeValues.ql.

Browse Source
This commit is contained in:
Geoffrey White
2018-08-23 10:47:45 +01:00
parent a125e3ed86
commit 87fb447c4b
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cpp/ql/src/Security/CWE/CWE-190/ArithmeticWithExtremeValues.ql
View File

@@ -35,18 +35,18 @@ predicate isMinValue(MacroInvocationExpr mie) {
class SecurityOptionsArith extends SecurityOptions {
override predicate isUserInput(Expr expr, string cause) {
(isMaxValue(expr) and cause = "max value") or
(isMinValue(expr) and cause = "min value")
(isMaxValue(expr) and cause = "overflow") or
(isMinValue(expr) and cause = "underflow")
}
}
predicate taintedVarAccess(Expr origin, VariableAccess va) {
isUserInput(origin, _) and
predicate taintedVarAccess(Expr origin, VariableAccess va, string cause) {
isUserInput(origin, cause) and
tainted(origin, va)
}
from Expr origin, Operation op, VariableAccess va, string effect
where taintedVarAccess(origin, va)
where taintedVarAccess(origin, va, effect)
and op.getAnOperand() = va
and
(