hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 18:25:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: address comments

Browse Source
This commit is contained in:
Asger F
2018-11-05 14:35:08 +00:00
parent 56707fc79a
commit 87e0027974
3 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
javascript/ql/src/Statements/UselessConditional.ql
View File

@@ -120,12 +120,11 @@ predicate whitelist(Expr e) {
*/
predicate isConditional(ASTNode cond, Expr e) {
e = cond.(IfStmt).getCondition() or
e = cond.(WhileStmt).getExpr() or
e = cond.(ForStmt).getTest() or
e = cond.(LoopStmt).getTest() or
e = cond.(ConditionalExpr).getCondition() or
e = cond.(LogicalBinaryExpr).getLeftOperand() or
// Include `z` in `if (x && z)`.
isConditional(_, cond) and e = cond.(LogicalBinaryExpr).getRightOperand()
isConditional(_, cond) and e = cond.(Expr).getUnderlyingValue().(LogicalBinaryExpr).getRightOperand()
}
from ASTNode cond, DataFlow::AnalyzedNode op, boolean cv, ASTNode sel, string msg