hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: address comments

Browse Source
This commit is contained in:
Asger F
2018-11-05 14:35:08 +00:00
parent 56707fc79a
commit 87e0027974
3 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
javascript/ql/src/Statements/UselessConditional.ql
View File

@@ -120,12 +120,11 @@ predicate whitelist(Expr e) {
*/
predicate isConditional(ASTNode cond, Expr e) {
e = cond.(IfStmt).getCondition() or
e = cond.(WhileStmt).getExpr() or
e = cond.(ForStmt).getTest() or
e = cond.(LoopStmt).getTest() or
e = cond.(ConditionalExpr).getCondition() or
e = cond.(LogicalBinaryExpr).getLeftOperand() or
// Include `z` in `if (x && z)`.
isConditional(_, cond) and e = cond.(LogicalBinaryExpr).getRightOperand()
isConditional(_, cond) and e = cond.(Expr).getUnderlyingValue().(LogicalBinaryExpr).getRightOperand()
}
from ASTNode cond, DataFlow::AnalyzedNode op, boolean cv, ASTNode sel, string msg

2
javascript/ql/test/query-tests/Statements/UselessConditional/UselessConditional.expected
View File

@@ -19,6 +19,8 @@
| UselessConditional.js:94:16:94:16 | x | This use of variable 'x' always evaluates to false. |
| UselessConditional.js:100:13:100:24 | true && true | This expression always evaluates to true. |
| UselessConditional.js:101:18:101:18 | x | This use of variable 'x' always evaluates to false. |
| UselessConditional.js:102:19:102:19 | x | This use of variable 'x' always evaluates to false. |
| UselessConditional.js:103:23:103:23 | x | This use of variable 'x' always evaluates to false. |
| UselessConditionalGood.js:58:12:58:13 | x2 | This use of variable 'x2' always evaluates to false. |
| UselessConditionalGood.js:69:12:69:13 | xy | This use of variable 'xy' always evaluates to false. |
| UselessConditionalGood.js:85:12:85:13 | xy | This use of variable 'xy' always evaluates to false. |

2
javascript/ql/test/query-tests/Statements/UselessConditional/UselessConditional.js
View File

@@ -99,6 +99,8 @@ async function awaitFlow(){
}
if (true && true) {} // NOT OK
if (y && x) {} // NOT OK
if (y && (x)) {} // NOT OK
do { } while (x); // NOT OK
}
});