hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

C#: Fix CFG for assertion.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2025-10-28 12:40:59 +01:00
parent e61ddf59d7
commit 87d89fd00f
1 changed files with 0 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
csharp/ql/lib/semmle/code/csharp/controlflow/internal/Completion.qll
View File

@@ -390,11 +390,6 @@ private predicate invalidCastCandidate(CastExpr ce) {
ce.getExpr().getType() = getACastExprBaseType(ce) ce.getExpr().getType() = getACastExprBaseType(ce)
} }
private predicate assertion(Assertion a, int i, AssertMethod am, Expr e) {
e = a.getExpr(i) and
am = a.getAssertMethod()
}
/** Gets a valid completion when argument `i` fails in assertion `a`. */ /** Gets a valid completion when argument `i` fails in assertion `a`. */
Completion assertionCompletion(Assertion a, int i) { Completion assertionCompletion(Assertion a, int i) {
exists(AssertMethod am | am = a.getAssertMethod() | exists(AssertMethod am | am = a.getAssertMethod() |
@@ -429,11 +424,6 @@ private predicate inBooleanContext(Expr e) {
or or
e = any(SpecificCatchClause scc).getFilterClause() e = any(SpecificCatchClause scc).getFilterClause()
or or
exists(BooleanAssertMethod m, int i |
assertion(_, i, m, e) and
i = m.getAnAssertionIndex(_)
)
or
e = any(LogicalNotExpr lne | inBooleanContext(lne)).getAnOperand() e = any(LogicalNotExpr lne | inBooleanContext(lne)).getAnOperand()
or or
exists(LogicalAndExpr lae | exists(LogicalAndExpr lae |
@@ -481,11 +471,6 @@ private predicate inNullnessContext(Expr e) {
or or
exists(QualifiableExpr qe | qe.isConditional() | e = qe.getChildExpr(-1)) exists(QualifiableExpr qe | qe.isConditional() | e = qe.getChildExpr(-1))
or or
exists(NullnessAssertMethod m, int i |
assertion(_, i, m, e) and
i = m.getAnAssertionIndex(_)
)
or
exists(ConditionalExpr ce | inNullnessContext(ce) | (e = ce.getThen() or e = ce.getElse())) exists(ConditionalExpr ce | inNullnessContext(ce) | (e = ce.getThen() or e = ce.getElse()))
or or
exists(NullCoalescingExpr nce | inNullnessContext(nce) | e = nce.getRightOperand()) exists(NullCoalescingExpr nce | inNullnessContext(nce) | e = nce.getRightOperand())