From 24d8c7ea174d3b93f208c2274699b3026d5b0300 Mon Sep 17 00:00:00 2001
From: Max Schaefer <54907921+max-schaefer@users.noreply.github.com>
Date: Fri, 15 May 2020 07:31:51 +0100
Subject: [PATCH] Clarify which types have a qualified name.

---
 ql/src/semmle/go/Types.qll | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/ql/src/semmle/go/Types.qll b/ql/src/semmle/go/Types.qll
index cee40d31410..1b246e3e904 100644
--- a/ql/src/semmle/go/Types.qll
+++ b/ql/src/semmle/go/Types.qll
@@ -25,11 +25,17 @@ class Type extends @type {
 
   /**
    * Gets the qualified name of this type, if any.
+   *
+   * Only (defined) named types like `io.Writer` have a qualified name. Basic types like `int`,
+   * pointer types like `*io.Writer`, and other composite types do not have a qualified name.
    */
   string getQualifiedName() { result = getEntity().getQualifiedName() }
 
   /**
    * Holds if this type is declared in a package with path `pkg` and has name `name`.
+   *
+   * Only (defined) named types like `io.Writer` have a qualified name. Basic types like `int`,
+   * pointer types like `*io.Writer`, and other composite types do not have a qualified name.
    */
   predicate hasQualifiedName(string pkg, string name) { getEntity().hasQualifiedName(pkg, name) }