hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-20 06:24:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Simplify 'isGlobalUse' and 'isGlobalDefImpl'.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2023-11-09 20:24:14 +00:00
parent 9762313500
commit 86e791980c
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternals.qll
View File

@@ -143,11 +143,10 @@ private newtype TDefOrUseImpl =
private predicate isGlobalUse(
GlobalLikeVariable v, IRFunction f, int indirection, int indirectionIndex
) {
exists(VariableAddressInstruction vai, int defIndex |
exists(VariableAddressInstruction vai |
vai.getEnclosingIRFunction() = f and
vai.getAstVariable() = v and
isDef(_, _, _, vai, indirection, defIndex) and
indirectionIndex = [0 .. defIndex] + 1
isDef(_, _, _, vai, indirection, indirectionIndex)
)
}
@@ -158,7 +157,7 @@ private predicate isGlobalDefImpl(
vai.getEnclosingIRFunction() = f and
vai.getAstVariable() = v and
isUse(_, _, vai, indirection, indirectionIndex) and
not isDef(_, _, vai.getAUse(), _, _, _)
not isDef(_, _, _, vai, _, indirectionIndex)
)
}