hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 04:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Move some alerts to their correct location

Browse Source 
One of the diffs look confusing but:
Previously parameter {2,3} where flagged, now parameter {1,2} are flagged.

Note that for command injection, the SystemCommandExecution is flagged
despite the test file claiming otherwise.
This commit is contained in:
Asger F
2025-02-11 15:17:10 +01:00
parent f5911c9e5a
commit 86932c51bc
18 changed files with 103 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
javascript/ql/test/query-tests/Electron/NodeIntegration/EnablingNodeIntegration.js
View File

@@ -1,30 +1,30 @@
const {BrowserWindow} = require('electron')
function test() {
var unsafe_1 = { // $ Alert - both enabled
var unsafe_1 = { // both enabled
webPreferences: {
nodeIntegration: true,
nodeIntegrationInWorker: true,
plugins: true,
webSecurity: true,
sandbox: true
}
} // $ Alert
};
var options_1 = { // $ Alert - `nodeIntegrationInWorker` enabled
var options_1 = { // `nodeIntegrationInWorker` enabled
webPreferences: {
plugins: true,
nodeIntegrationInWorker: false,
webSecurity: true,
sandbox: true
}
} // $ Alert
};
var pref = { // $ Alert - implicitly enabled
var pref = { // implicitly enabled
plugins: true,
webSecurity: true,
sandbox: true
};
}; // $ Alert
var options_2 = { // $ Alert - implicitly enabled
webPreferences: pref,