diff --git a/go/ql/lib/semmle/go/Concepts.qll b/go/ql/lib/semmle/go/Concepts.qll index acb16b62d07..4e328ed76c4 100644 --- a/go/ql/lib/semmle/go/Concepts.qll +++ b/go/ql/lib/semmle/go/Concepts.qll @@ -116,10 +116,10 @@ module FileSystemAccess { } } -private class DefaultFileSystemAccess extends FileSystemAccess::Range, DataFlow::CallNode { +private class ExternalFileSystemAccess extends FileSystemAccess::Range, DataFlow::CallNode { DataFlow::ArgumentNode pathArgument; - DefaultFileSystemAccess() { + ExternalFileSystemAccess() { sinkNode(pathArgument, "path-injection") and this = pathArgument.getCall() } @@ -394,10 +394,10 @@ module LoggerCall { } } -private class DefaultLoggerCall extends LoggerCall::Range, DataFlow::CallNode { +private class ExternalLoggerCall extends LoggerCall::Range, DataFlow::CallNode { DataFlow::ArgumentNode messageComponent; - DefaultLoggerCall() { + ExternalLoggerCall() { sinkNode(messageComponent, "log-injection") and this = messageComponent.getCall() } diff --git a/go/ql/lib/semmle/go/concepts/HTTP.qll b/go/ql/lib/semmle/go/concepts/HTTP.qll index 479cc19bfcc..b3990edd084 100644 --- a/go/ql/lib/semmle/go/concepts/HTTP.qll +++ b/go/ql/lib/semmle/go/concepts/HTTP.qll @@ -320,11 +320,11 @@ module Http { ) } - private class DefaultHttpRedirect extends Range, DataFlow::CallNode { + private class ExternalHttpRedirect extends Range, DataFlow::CallNode { DataFlow::ArgumentNode url; int rw; - DefaultHttpRedirect() { + ExternalHttpRedirect() { this = url.getCall() and exists(string kind | sinkKindInfo(kind, rw) and diff --git a/go/ql/lib/semmle/go/frameworks/NoSQL.qll b/go/ql/lib/semmle/go/frameworks/NoSQL.qll index 5fa155395fc..2772182f4fc 100644 --- a/go/ql/lib/semmle/go/frameworks/NoSQL.qll +++ b/go/ql/lib/semmle/go/frameworks/NoSQL.qll @@ -24,8 +24,8 @@ module NoSql { */ abstract class Range extends DataFlow::Node { } - private class DefaultQueryString extends Range { - DefaultQueryString() { + private class ExternalQueryString extends Range { + ExternalQueryString() { exists(DataFlow::ArgumentNode arg | sinkNode(arg, "nosql-injection") | this = arg.getACorrespondingSyntacticArgument() ) diff --git a/go/ql/lib/semmle/go/frameworks/SQL.qll b/go/ql/lib/semmle/go/frameworks/SQL.qll index a0e80fde1c9..c5cf4989d1a 100644 --- a/go/ql/lib/semmle/go/frameworks/SQL.qll +++ b/go/ql/lib/semmle/go/frameworks/SQL.qll @@ -67,8 +67,8 @@ module SQL { */ abstract class Range extends DataFlow::Node { } - private class DefaultQueryString extends Range { - DefaultQueryString() { + private class ExternalQueryString extends Range { + ExternalQueryString() { exists(DataFlow::ArgumentNode arg | sinkNode(arg, "sql-injection") | not arg instanceof DataFlow::ImplicitVarargsSlice and this = arg diff --git a/go/ql/lib/semmle/go/frameworks/SystemCommandExecutors.qll b/go/ql/lib/semmle/go/frameworks/SystemCommandExecutors.qll index 1bd7054d5c3..8abf2bbd368 100644 --- a/go/ql/lib/semmle/go/frameworks/SystemCommandExecutors.qll +++ b/go/ql/lib/semmle/go/frameworks/SystemCommandExecutors.qll @@ -5,12 +5,12 @@ import go -private class DefaultSystemCommandExecution extends SystemCommandExecution::Range, +private class ExternalSystemCommandExecution extends SystemCommandExecution::Range, DataFlow::CallNode { DataFlow::ArgumentNode commandName; - DefaultSystemCommandExecution() { + ExternalSystemCommandExecution() { sinkNode(commandName, "command-injection") and this = commandName.getCall() } diff --git a/go/ql/lib/semmle/go/frameworks/XPath.qll b/go/ql/lib/semmle/go/frameworks/XPath.qll index 30383a01505..a6d19009bf4 100644 --- a/go/ql/lib/semmle/go/frameworks/XPath.qll +++ b/go/ql/lib/semmle/go/frameworks/XPath.qll @@ -25,8 +25,8 @@ module XPath { */ abstract class Range extends DataFlow::Node { } - private class DefaultXPathExpressionString extends Range { - DefaultXPathExpressionString() { sinkNode(this, "xpath-injection") } + private class ExternalXPathExpressionString extends Range { + ExternalXPathExpressionString() { sinkNode(this, "xpath-injection") } } } diff --git a/go/ql/lib/semmle/go/frameworks/stdlib/Regexp.qll b/go/ql/lib/semmle/go/frameworks/stdlib/Regexp.qll index 525eb73d5b9..b8ab8cb9cd3 100644 --- a/go/ql/lib/semmle/go/frameworks/stdlib/Regexp.qll +++ b/go/ql/lib/semmle/go/frameworks/stdlib/Regexp.qll @@ -39,10 +39,10 @@ module Regexp { ) } - private class DefaultRegexpPattern extends RegexpPattern::Range, DataFlow::ArgumentNode { + private class ExternalRegexpPattern extends RegexpPattern::Range, DataFlow::ArgumentNode { int strArg; - DefaultRegexpPattern() { + ExternalRegexpPattern() { exists(string kind | regexSinkKindInfo(kind, strArg) and sinkNode(this, kind) @@ -61,12 +61,12 @@ module Regexp { } } - private class DefaultRegexpMatchFunction extends RegexpMatchFunction::Range, Function { + private class ExternalRegexpMatchFunction extends RegexpMatchFunction::Range, Function { int patArg; int strArg; - DefaultRegexpMatchFunction() { - exists(DefaultRegexpPattern drp, string kind | + ExternalRegexpMatchFunction() { + exists(ExternalRegexpPattern drp, string kind | drp.getCall() = this.getACall() and sinkNode(drp, kind) | diff --git a/go/ql/lib/semmle/go/security/HardcodedCredentials.qll b/go/ql/lib/semmle/go/security/HardcodedCredentials.qll index 0365efed3bc..1802d48cdd7 100644 --- a/go/ql/lib/semmle/go/security/HardcodedCredentials.qll +++ b/go/ql/lib/semmle/go/security/HardcodedCredentials.qll @@ -43,8 +43,8 @@ module HardcodedCredentials { } /** A use of a credential. */ - private class CredentialsSink extends Sink { - CredentialsSink() { exists(string s | s.matches("credentials-%") | sinkNode(this, s)) } + private class ExternalCredentialsSink extends Sink { + ExternalCredentialsSink() { exists(string s | s.matches("credentials-%") | sinkNode(this, s)) } } /** A use of a credential. */ diff --git a/go/ql/lib/semmle/go/security/MissingJwtSignatureCheckCustomizations.qll b/go/ql/lib/semmle/go/security/MissingJwtSignatureCheckCustomizations.qll index f86132352e3..24c3550450a 100644 --- a/go/ql/lib/semmle/go/security/MissingJwtSignatureCheckCustomizations.qll +++ b/go/ql/lib/semmle/go/security/MissingJwtSignatureCheckCustomizations.qll @@ -51,8 +51,8 @@ module MissingJwtSignatureCheck { private class DefaultSource extends Source instanceof ActiveThreatModelSource { } - private class DefaultSink extends Sink { - DefaultSink() { sinkNode(this, "jwt") } + private class ExternalSink extends Sink { + ExternalSink() { sinkNode(this, "jwt") } } private class ExternalSanitizer extends Sanitizer { diff --git a/go/ql/lib/semmle/go/security/RequestForgeryCustomizations.qll b/go/ql/lib/semmle/go/security/RequestForgeryCustomizations.qll index bdb341f5525..d80026aeed5 100644 --- a/go/ql/lib/semmle/go/security/RequestForgeryCustomizations.qll +++ b/go/ql/lib/semmle/go/security/RequestForgeryCustomizations.qll @@ -44,10 +44,10 @@ module RequestForgery { */ private class ThreatModelFlowAsSource extends Source instanceof ActiveThreatModelSource { } - private class DefaultRequestForgerySink extends Sink { + private class ExternalRequestForgerySink extends Sink { string kind; - DefaultRequestForgerySink() { + ExternalRequestForgerySink() { exists(string modelKind | sinkNode(this, modelKind) | modelKind = "request-forgery" and kind = "URL" or diff --git a/go/ql/lib/semmle/go/security/Xss.qll b/go/ql/lib/semmle/go/security/Xss.qll index 0f71ad717ae..6ab9f7321f6 100644 --- a/go/ql/lib/semmle/go/security/Xss.qll +++ b/go/ql/lib/semmle/go/security/Xss.qll @@ -49,8 +49,8 @@ module SharedXss { override Locatable getAssociatedLoc() { result = this.getRead().getEnclosingTextNode() } } - private class DefaultSink extends Sink { - DefaultSink() { sinkNode(this, ["html-injection", "js-injection"]) } + private class ExternalSink extends Sink { + ExternalSink() { sinkNode(this, ["html-injection", "js-injection"]) } } /**