hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-22 19:56:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
This commit is contained in:
yoff
2022-03-25 11:42:32 +01:00
committed by GitHub
parent ce017394e6
commit 85f1d92a0d
3 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
python/ql/lib/semmle/python/Concepts.qll
View File

@@ -106,7 +106,7 @@ module FileSystemWriteAccess {
} }
/** /**
* A data-flow node that may set or unset Cross-site request forgery protection * A data-flow node that enables or disables Cross-site request forgery protection
* in a global manner. * in a global manner.
* *
* Extend this class to refine existing API models. If you want to model new APIs, * Extend this class to refine existing API models. If you want to model new APIs,

8
python/ql/lib/semmle/python/frameworks/Django.qll
View File

@@ -2330,8 +2330,12 @@ module PrivateDjango {
mw.asVar().getName() = "MIDDLEWARE" and mw.asVar().getName() = "MIDDLEWARE" and
DataFlow::localFlow(this, mw) DataFlow::localFlow(this, mw)
| |
// it only counts as setting the CSRF protection, if the app uses authentication, // To only include results where CSRF protection matters, we only care about CSRF
// so check that the list contains the django authentication middleware. // protection when the django authentication middleware is enabled.
// Since an active session cookie is exactly what would allow an attacker to perform
// a CSRF attack.
// Notice that this does not ensure that this is not a FP, since the authentication
// middleware might be unused.
// //
// This also strongly implies that we are actually looking at the `MIDDLEWARE` setting. // This also strongly implies that we are actually looking at the `MIDDLEWARE` setting.
list.getAnElt().(StrConst).getText() = list.getAnElt().(StrConst).getText() =

2
python/ql/src/Security/CWE-352/CSRFProtectionDisabled.qhelp
View File

@@ -6,7 +6,7 @@
<overview> <overview>
<p> <p>
Cross-site request forgery (CSRF) is a type of vulnerability in which an Cross-site request forgery (CSRF) is a type of vulnerability in which an
attacker is able to force a user carry out an action that the user did attacker is able to force a user to carry out an action that the user did
not intend. not intend.
</p> </p>