hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 17:25:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix naming of OSCheck method

Browse Source
This commit is contained in:
Jonathan Leitschuh
2022-03-02 19:41:46 -05:00
parent a7adbb7291
commit 85de9f305e
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
java/ql/lib/semmle/code/java/os/OSCheck.qll
View File

@@ -71,7 +71,7 @@ private class IsWindowsFromSystemProp extends IsWindowsGuard instanceof MethodAc
* Holds when the Guard is an equality check between the system property with the name `propertyName`
* and the string or char constant `compareToLiteral`.
*/
private Guard isOsFromFieldEqualityCheck(string propertyName, string compareToLiteral) {
private Guard isOsFromSystemPropertyEqualityCheck(string propertyName, string compareToLiteral) {
result
.isEquality(getSystemProperty(propertyName),
any(Literal literal |
@@ -81,19 +81,19 @@ private Guard isOsFromFieldEqualityCheck(string propertyName, string compareToLi
}
private class IsWindowsFromCharPathSeperator extends IsWindowsGuard {
IsWindowsFromCharPathSeperator() { this = isOsFromFieldEqualityCheck("path.separator", "\\") }
IsWindowsFromCharPathSeperator() { this = isOsFromSystemPropertyEqualityCheck("path.separator", "\\") }
}
private class IsWindowsFromCharSeperator extends IsWindowsGuard {
IsWindowsFromCharSeperator() { this = isOsFromFieldEqualityCheck("file.separator", ";") }
IsWindowsFromCharSeperator() { this = isOsFromSystemPropertyEqualityCheck("file.separator", ";") }
}
private class IsUnixFromCharPathSeperator extends IsUnixGuard {
IsUnixFromCharPathSeperator() { this = isOsFromFieldEqualityCheck("path.separator", "/") }
IsUnixFromCharPathSeperator() { this = isOsFromSystemPropertyEqualityCheck("path.separator", "/") }
}
private class IsUnixFromCharSeperator extends IsUnixGuard {
IsUnixFromCharSeperator() { this = isOsFromFieldEqualityCheck("file.separator", ":") }
IsUnixFromCharSeperator() { this = isOsFromSystemPropertyEqualityCheck("file.separator", ":") }
}
private class IsUnixFromSystemProp extends IsAnyUnixGuard instanceof MethodAccess {