mirror of
https://github.com/github/codeql.git
synced 2026-05-01 11:45:14 +02:00
JS: Fix copy/paste error in XSS ML-powered queries results patterns
We didn’t catch this because our unit tests test only library code due to the previous difficulty of running queries with an ML model (the ML models in packs work should fix that), and because the end-to-end evaluation runs separate queries that have different result patterns. Going forward we should create unit tests for the queries themselves, which will require using the ML model in tests. We should also be able to catch this type of error using DCA.
This commit is contained in:
@@ -23,5 +23,5 @@ where
|
||||
not isFlowLikelyInBaseQuery(source.getNode(), sink.getNode()) and
|
||||
score = getScoreForFlow(source.getNode(), sink.getNode())
|
||||
select sink.getNode(), source, sink,
|
||||
"(Experimental) This may be a cross-site scripting vulnerability due to $@. Identified using machine learning."
|
||||
+ "a user-provided value", score
|
||||
"(Experimental) This may be a cross-site scripting vulnerability due to $@. Identified using machine learning.",
|
||||
source.getNode(), "a user-provided value", score
|
||||
|
||||
Reference in New Issue
Block a user