hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-04 13:15:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #20917 from owen-mc/go/enable-data-flow-consistency-checks

Browse Source 
Go: enable data flow consistency checks
This commit is contained in:
Owen Mansel-Chan
2025-12-02 10:52:47 +00:00
committed by GitHub
parent 464d2cd5fc 38cb6e5a00
commit 848677e580
71 changed files with 957 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
go/ql/test/query-tests/InconsistentCode/InconsistentLoopOrientation/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,6 @@
identityLocalStep
| InconsistentLoopOrientation.go:6:3:6:3 | a | Node steps to itself |
| InconsistentLoopOrientationGood.go:6:3:6:3 | a | Node steps to itself |
| main.go:9:26:9:26 | s | Node steps to itself |
| main.go:14:29:14:29 | l | Node steps to itself |
| main.go:20:3:20:3 | a | Node steps to itself |

3
go/ql/test/query-tests/InconsistentCode/LengthComparisonOffByOne/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,3 @@
identityLocalStep
| LengthComparisonOffByOne.go:10:19:10:28 | searchName | Node steps to itself |
| LengthComparisonOffByOneGood.go:9:14:9:23 | searchName | Node steps to itself |

4
go/ql/test/query-tests/RedundantCode/DeadStoreOfLocal/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,4 @@
reverseRead
| testdata.go:206:7:206:7 | x | Origin of readStep is missing a PostUpdateNode. |
identityLocalStep
| testdata.go:583:7:583:7 | x | Node steps to itself |

3
go/ql/test/query-tests/RedundantCode/UnreachableStatement/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,3 @@
identityLocalStep
| main.go:35:6:35:9 | cond | Node steps to itself |
| main.go:44:6:44:9 | cond | Node steps to itself |

5
go/ql/test/query-tests/Security/CWE-020/IncompleteHostnameRegexp/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,5 @@
reverseRead
| IncompleteHostnameRegexp.go:12:42:12:44 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| IncompleteHostnameRegexpGood2.go:12:42:12:44 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| IncompleteHostnameRegexpGood.go:12:42:12:44 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| main.go:18:57:18:57 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

3
go/ql/test/query-tests/Security/CWE-020/MissingRegexpAnchor/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,3 @@
reverseRead
| MissingRegexpAnchor.go:12:42:12:44 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| MissingRegexpAnchorGood.go:12:42:12:44 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

22
go/ql/test/query-tests/Security/CWE-022/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,22 @@
reverseRead
| TaintedPath.go:15:18:15:18 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| TaintedPath.go:84:28:84:32 | files | Origin of readStep is missing a PostUpdateNode. |
identityLocalStep
| UnsafeUnzipSymlink.go:26:18:26:18 | r | Node steps to itself |
| UnsafeUnzipSymlink.go:30:29:30:34 | target | Node steps to itself |
| UnsafeUnzipSymlink.go:42:22:42:27 | target | Node steps to itself |
| UnsafeUnzipSymlink.go:58:18:58:18 | r | Node steps to itself |
| UnsafeUnzipSymlink.go:62:3:62:7 | links | Node steps to itself |
| UnsafeUnzipSymlink.go:79:18:79:18 | r | Node steps to itself |
| UnsafeUnzipSymlink.go:85:29:85:34 | target | Node steps to itself |
| UnsafeUnzipSymlink.go:94:18:94:18 | r | Node steps to itself |
| UnsafeUnzipSymlink.go:98:29:98:34 | target | Node steps to itself |
| UnsafeUnzipSymlink.go:121:32:121:32 | r | Node steps to itself |
| UnsafeUnzipSymlink.go:125:29:125:34 | target | Node steps to itself |
| UnsafeUnzipSymlink.go:146:32:146:32 | r | Node steps to itself |
| UnsafeUnzipSymlink.go:150:29:150:34 | target | Node steps to itself |
| UnsafeUnzipSymlinkGood.go:30:18:30:18 | r | Node steps to itself |
| UnsafeUnzipSymlinkGood.go:34:33:34:38 | target | Node steps to itself |
| UnsafeUnzipSymlinkGood.go:46:26:46:31 | target | Node steps to itself |
| UnsafeUnzipSymlinkGood.go:72:18:72:18 | r | Node steps to itself |
| UnsafeUnzipSymlinkGood.go:76:41:76:46 | target | Node steps to itself |

11
go/ql/test/query-tests/Security/CWE-078/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,11 @@
reverseRead
| ArgumentInjection.go:9:10:9:12 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| CommandInjection2.go:13:15:13:17 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| CommandInjection2.go:21:15:21:17 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| CommandInjection2.go:41:15:41:17 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| CommandInjection.go:9:13:9:15 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| GitSubcommands.go:11:13:11:15 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| GitSubcommands.go:22:13:22:15 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| GitSubcommands.go:33:13:33:15 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| SanitizingDoubleDash.go:9:13:9:15 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| SanitizingDoubleDash.go:92:13:92:15 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

26
go/ql/test/query-tests/Security/CWE-079/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,26 @@
reverseRead
| HtmlTemplateEscapingBypassXss.go:99:9:99:9 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| ReflectedXss.go:11:15:11:15 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| ReflectedXssGood.go:15:15:15:15 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| contenttype.go:11:11:11:11 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| contenttype.go:25:11:25:11 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| contenttype.go:39:11:39:11 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| contenttype.go:49:11:49:11 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| contenttype.go:61:11:61:11 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| contenttype.go:71:11:71:11 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| contenttype.go:86:11:86:11 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| contenttype.go:98:11:98:11 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| contenttype.go:111:11:111:11 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| reflectedxsstest.go:15:13:15:13 | r | Origin of readStep is missing a PostUpdateNode. |
| reflectedxsstest.go:21:13:21:13 | r | Origin of readStep is missing a PostUpdateNode. |
| reflectedxsstest.go:51:14:51:14 | r | Origin of readStep is missing a PostUpdateNode. |
| tst.go:14:15:14:15 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| tst.go:33:15:33:15 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| tst.go:48:14:48:14 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| tst.go:66:15:66:15 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| websocketXss.go:26:9:26:9 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
identityLocalStep
| StoredXss.go:13:18:13:18 | w | Node steps to itself |
| StoredXssGood.go:17:3:17:10 | template | Node steps to itself |
| stored.go:30:19:30:19 | w | Node steps to itself |
| stored.go:51:20:51:20 | w | Node steps to itself |

23
go/ql/test/query-tests/Security/CWE-089/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,23 @@
reverseRead
| SqlInjection.go:11:3:11:5 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| SqlInjection.go:11:3:11:17 | call to Query | Origin of readStep is missing a PostUpdateNode. |
| SqlInjectionGood.go:10:14:10:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| SqlInjectionGood.go:10:14:10:28 | call to Query | Origin of readStep is missing a PostUpdateNode. |
| issue48.go:17:25:17:27 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| issue48.go:21:3:21:21 | RequestDataFromJson | Origin of readStep is missing a PostUpdateNode. |
| issue48.go:27:26:27:28 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| issue48.go:31:3:31:22 | RequestDataFromJson2 | Origin of readStep is missing a PostUpdateNode. |
| issue48.go:37:24:37:26 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| issue48.go:40:3:40:22 | RequestDataFromJson3 | Origin of readStep is missing a PostUpdateNode. |
| main.go:15:63:15:63 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| main.go:15:63:15:75 | call to Query | Origin of readStep is missing a PostUpdateNode. |
| main.go:16:63:16:63 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| main.go:30:13:30:15 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| main.go:34:3:34:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| main.go:40:25:40:27 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| main.go:43:3:43:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| main.go:49:28:49:30 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| main.go:52:3:52:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| main.go:58:28:58:30 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| main.go:61:4:61:15 | star expression | Origin of readStep is missing a PostUpdateNode. |
| main.go:68:18:68:20 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

11
go/ql/test/query-tests/Security/CWE-117/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,11 @@
reverseRead
| LogInjection.go:32:14:32:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| LogInjection.go:33:14:33:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| LogInjection.go:34:18:34:20 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| LogInjection.go:35:14:35:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| LogInjection.go:447:14:447:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| LogInjection.go:455:14:455:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| LogInjection.go:463:14:463:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| LogInjection.go:498:14:498:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| LogInjection.go:499:14:499:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| LogInjection.go:724:12:724:14 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

3
go/ql/test/query-tests/Security/CWE-190/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,3 @@
reverseRead
| array_vs_contents.go:16:25:16:31 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| array_vs_contents.go:33:25:33:31 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

34
go/ql/test/query-tests/Security/CWE-312/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,34 @@
reverseRead
| CleartextLogging.go:11:11:11:11 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| CleartextLogging.go:12:9:12:9 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| CleartextLoggingGood.go:12:11:12:11 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| CleartextLoggingGood.go:13:9:13:9 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| CleartextLoggingGood.go:25:14:25:14 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| klog.go:27:13:27:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| klog.go:28:13:28:20 | selection of Header | Origin of readStep is missing a PostUpdateNode. |
| klog.go:29:13:29:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| protos/query/query.pb.go:58:9:58:34 | file_query_proto_enumTypes | Origin of readStep is missing a PostUpdateNode. |
| protos/query/query.pb.go:62:10:62:35 | file_query_proto_enumTypes | Origin of readStep is missing a PostUpdateNode. |
| protos/query/query.pb.go:88:10:88:34 | file_query_proto_msgTypes | Origin of readStep is missing a PostUpdateNode. |
| protos/query/query.pb.go:101:9:101:33 | file_query_proto_msgTypes | Origin of readStep is missing a PostUpdateNode. |
| protos/query/query.pb.go:156:10:156:34 | file_query_proto_msgTypes | Origin of readStep is missing a PostUpdateNode. |
| protos/query/query.pb.go:169:9:169:33 | file_query_proto_msgTypes | Origin of readStep is missing a PostUpdateNode. |
| protos/query/query.pb.go:204:10:204:34 | file_query_proto_msgTypes | Origin of readStep is missing a PostUpdateNode. |
| protos/query/query.pb.go:217:9:217:33 | file_query_proto_msgTypes | Origin of readStep is missing a PostUpdateNode. |
| protos/query/query.pb.go:318:13:318:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| protos/query/query.pb.go:320:13:320:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| protos/query/query.pb.go:322:13:322:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| protos/query/query.pb.go:330:13:330:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| protos/query/query.pb.go:332:13:332:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| protos/query/query.pb.go:334:13:334:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| protos/query/query.pb.go:342:13:342:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| protos/query/query.pb.go:344:13:344:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| protos/query/query.pb.go:346:13:346:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| server1.go:11:11:11:11 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| server1.go:13:11:13:11 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| server1.go:14:11:14:14 | vals | Origin of readStep is missing a PostUpdateNode. |
| server1.go:17:41:17:41 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| server1.go:21:46:21:46 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
identityLocalStep
| klog.go:24:20:24:23 | name | Node steps to itself |
| server1.go:29:3:29:3 | s | Node steps to itself |

6
go/ql/test/query-tests/Security/CWE-327/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,6 @@
reverseRead
| UnsafeTLS.go:329:32:329:37 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| UnsafeTLS.go:336:33:336:38 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| UnsafeTLS.go:353:40:353:45 | suites | Origin of readStep is missing a PostUpdateNode. |
identityLocalStep
| UnsafeTLS.go:353:40:353:45 | suites | Node steps to itself |

3
go/ql/test/query-tests/Security/CWE-338/InsecureRandomness/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,3 @@
identityLocalStep
| InsecureRandomness.go:12:3:12:3 | s | Node steps to itself |
| InsecureRandomnessGood.go:15:3:15:3 | s | Node steps to itself |

5
go/ql/test/query-tests/Security/CWE-347/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,5 @@
reverseRead
| go-jose.v3.go:19:17:19:17 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| go-jose.v3.go:25:16:25:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| golang-jwt-v5.go:22:17:22:17 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| golang-jwt-v5.go:28:16:28:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

3
go/ql/test/query-tests/Security/CWE-601/BadRedirectCheck/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,3 @@
reverseRead
| cves.go:33:14:33:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| cves.go:41:14:41:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

26
go/ql/test/query-tests/Security/CWE-601/OpenUrlRedirect/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,26 @@
reverseRead
| OpenUrlRedirect.go:10:23:10:23 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| OpenUrlRedirectGood.go:12:16:12:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:13:13:13:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:22:13:22:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:33:13:33:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:48:13:48:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:56:13:56:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:68:13:68:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:77:13:77:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:85:13:85:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:93:13:93:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:102:13:102:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:115:6:115:6 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:117:24:117:24 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:126:13:126:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:138:13:138:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:150:13:150:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:163:11:163:11 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:176:6:176:6 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:177:35:177:35 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:220:3:220:3 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:226:23:226:23 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:227:23:227:23 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:228:23:228:23 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| stdlib.go:232:23:232:33 | call to Cookies | Origin of readStep is missing a PostUpdateNode. |

2
go/ql/test/query-tests/Security/CWE-640/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,2 @@
reverseRead
| EmailBad.go:9:10:9:10 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

13
go/ql/test/query-tests/Security/CWE-643/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,13 @@
reverseRead
| XPathInjection.go:13:14:13:14 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| tst.go:35:14:35:14 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| tst.go:46:14:46:14 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| tst.go:57:14:57:14 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| tst.go:72:14:72:14 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| tst.go:83:14:83:14 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| tst.go:92:14:92:14 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| tst.go:93:14:93:14 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| tst.go:106:14:106:14 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| tst.go:115:14:115:14 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| tst.go:116:14:116:14 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| tst.go:139:14:139:14 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

17
go/ql/test/query-tests/Security/CWE-770/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,17 @@
reverseRead
| UncontrolledAllocationSizeBad.go:11:12:11:12 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| UncontrolledAllocationSizeGood.go:11:12:11:12 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| UncontrolledAllocationSizeGood.go:32:12:32:12 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| UncontrolledAllocationSizeGood.go:52:12:52:12 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| UncontrolledAllocationSizeGood.go:73:12:73:12 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
identityLocalStep
| UncontrolledAllocationSizeBad.go:21:18:21:21 | sink | Node steps to itself |
| UncontrolledAllocationSizeBad.go:22:3:22:8 | result | Node steps to itself |
| UncontrolledAllocationSizeGood.go:23:18:23:21 | sink | Node steps to itself |
| UncontrolledAllocationSizeGood.go:24:3:24:8 | result | Node steps to itself |
| UncontrolledAllocationSizeGood.go:42:19:42:22 | sink | Node steps to itself |
| UncontrolledAllocationSizeGood.go:43:4:43:9 | result | Node steps to itself |
| UncontrolledAllocationSizeGood.go:63:19:63:22 | sink | Node steps to itself |
| UncontrolledAllocationSizeGood.go:64:4:64:9 | result | Node steps to itself |
| UncontrolledAllocationSizeGood.go:88:18:88:21 | sink | Node steps to itself |
| UncontrolledAllocationSizeGood.go:89:3:89:8 | result | Node steps to itself |

9
go/ql/test/query-tests/Security/CWE-798/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,9 @@
identityLocalStep
| HardcodedKeysGood.go:20:3:20:5 | ret | Node steps to itself |
| sanitizer.go:26:3:26:7 | bytes | Node steps to itself |
| sanitizer.go:39:3:39:5 | ret | Node steps to itself |
| sanitizer.go:49:3:49:7 | bytes | Node steps to itself |
| sanitizer.go:70:12:70:17 | length | Node steps to itself |
| sanitizer.go:71:27:71:33 | sources | Node steps to itself |
| sanitizer.go:71:35:71:35 | r | Node steps to itself |
| sanitizer.go:71:42:71:53 | sourceLength | Node steps to itself |

5
go/ql/test/query-tests/Security/CWE-918/CONSISTENCY/DataFlowConsistency.expected Normal file
View File

@@ -0,0 +1,5 @@
reverseRead
| websocket.go:110:31:110:31 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| websocket.go:120:32:120:32 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| websocket.go:129:54:129:54 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
| websocket.go:139:55:139:55 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |