From 844171a28ebcd174754a6264e4fc807ba8dbd410 Mon Sep 17 00:00:00 2001 From: tiferet Date: Thu, 12 Jan 2023 16:40:14 -0800 Subject: [PATCH] Simplify the definition of `ExtractPositiveExamples.ql` --- .../src/ExtractPositiveExamples.ql | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/java/ql/experimental/adaptivethreatmodeling/src/ExtractPositiveExamples.ql b/java/ql/experimental/adaptivethreatmodeling/src/ExtractPositiveExamples.ql index ad283f9baf6..7319c68e11d 100644 --- a/java/ql/experimental/adaptivethreatmodeling/src/ExtractPositiveExamples.ql +++ b/java/ql/experimental/adaptivethreatmodeling/src/ExtractPositiveExamples.ql @@ -21,14 +21,10 @@ private import experimental.adaptivethreatmodeling.RequestForgeryATM as RequestF * the ML-gnerarated, noisy sinks will end up poluting the positive examples used in the prompt! */ -from - DataFlow::Node sink, AtmConfig::AtmConfig config, - EndpointCharacteristics::EndpointCharacteristic characteristic, float confidence +from DataFlow::Node sink, AtmConfig::AtmConfig config where - characteristic.appliesToEndpoint(sink) and - confidence >= characteristic.maximalConfidence() and - characteristic.hasImplications(config.getASinkEndpointType(), true, confidence) and + config.isKnownSink(sink) and // If there are _any_ erroneous endpoints, return nothing. This will prevent us from accidentally running this query // when there's a codex-generated data extension file in `java/ql/lib/ext`. not EndpointCharacteristics::erroneousEndpoints(_, _, _, _, _) -select sink, characteristic.toString() +select sink, config.getASinkEndpointType().getDescription()