hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add visibility constraints; Fix non-compliant code

Browse Source
This commit is contained in:
Emile El-Qawas
2021-09-23 09:55:49 +01:00
parent dcae1c5c04
commit 83fb41e414
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/src/Likely Bugs/Concurrency/DateFormatThreadUnsafe.java
View File

@@ -1,5 +1,5 @@
class DateFormattingThread implements Runnable { class DateFormattingThread implements Runnable {
private static DateFormat dateF = new SimpleDateFormat("yyyyMMdd"); // Static field declared public static DateFormat dateF = new SimpleDateFormat("yyyyMMdd"); // Static field declared
public void run() { public void run() {
for(int i=0; i < 10; i++){ for(int i=0; i < 10; i++){

1
java/ql/src/Likely Bugs/Concurrency/DateFormatThreadUnsafe.ql
View File

@@ -16,6 +16,7 @@ import java
from Field f, Class dateFormat from Field f, Class dateFormat
where where
f.isStatic() and f.isStatic() and
(f.isPublic() or f.isProtected()) and
dateFormat.hasQualifiedName("java.text", "DateFormat") and dateFormat.hasQualifiedName("java.text", "DateFormat") and
f.getType().(RefType).hasSupertype*(dateFormat) and f.getType().(RefType).hasSupertype*(dateFormat) and
exists(MethodAccess m | m.getQualifier().(VarAccess).getVariable() = f) exists(MethodAccess m | m.getQualifier().(VarAccess).getVariable() = f)