hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 19:55:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

trim the whitespace in the poly-redos examples

Browse Source
This commit is contained in:
erik-krogh
2023-05-15 14:45:57 +02:00
parent d989359656
commit 83ca1495e0
4 changed files with 27 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
javascript/ql/src/Performance/PolynomialReDoS.qhelp
View File

@@ -15,8 +15,7 @@
</p>
<sample language="javascript">
text.replace(/^\s+|\s+$/g, ''); // BAD
</sample>
text.replace(/^\s+|\s+$/g, ''); // BAD</sample>
<p>
@@ -71,8 +70,7 @@
</p>
<sample language="javascript">
/^0\.\d+E?\d+$/.test(str) // BAD
</sample>
/^0\.\d+E?\d+$/.test(str) // BAD</sample>
<p>
@@ -113,8 +111,7 @@
</p>
<sample language="javascript">
/^(\+|-)?(\d+|(\d*\.\d*))?(E|e)?([-+])?(\d+)?$/.test(str) // BAD
</sample>
/^(\+|-)?(\d+|(\d*\.\d*))?(E|e)?([-+])?(\d+)?$/.test(str) // BAD</sample>
<p>
It's not immediately obvious how to rewrite this regular expression
@@ -124,11 +121,10 @@
</p>
<sample language="javascript">
if (str.length &gt; 1000) {
throw new Error("Input too long");
}
/^(\+|-)?(\d+|(\d*\.\d*))?(E|e)?([-+])?(\d+)?$/.test(str)
</sample>
if (str.length &gt; 1000) {
throw new Error("Input too long");
}
/^(\+|-)?(\d+|(\d*\.\d*))?(E|e)?([-+])?(\d+)?$/.test(str)</sample>
</example>
<include src="ReDoSReferences.inc.qhelp"/>