From 83bcd26244e981bf239b6431a21cf805592a51e6 Mon Sep 17 00:00:00 2001
From: Arthur Baars <aibaars@github.com>
Date: Thu, 4 Feb 2021 16:09:50 +0100
Subject: [PATCH] Add dataflow step tests

---
 .../dataflow/local/DataflowStep.expected      | 19 +++++++++++++++++++
 .../dataflow/local/DataflowStep.ql            |  6 ++++++
 .../dataflow/local/local_dataflow.rb          |  7 +++++++
 3 files changed, 32 insertions(+)
 create mode 100644 ql/test/library-tests/dataflow/local/DataflowStep.expected
 create mode 100644 ql/test/library-tests/dataflow/local/DataflowStep.ql
 create mode 100644 ql/test/library-tests/dataflow/local/local_dataflow.rb

diff --git a/ql/test/library-tests/dataflow/local/DataflowStep.expected b/ql/test/library-tests/dataflow/local/DataflowStep.expected
new file mode 100644
index 00000000000..b920f8a2876
--- /dev/null
+++ b/ql/test/library-tests/dataflow/local/DataflowStep.expected
@@ -0,0 +1,19 @@
+| local_dataflow.rb:1:9:1:9 | a | local_dataflow.rb:2:7:2:7 | a |
+| local_dataflow.rb:2:3:2:7 | ... = ... | local_dataflow.rb:3:13:3:13 | b |
+| local_dataflow.rb:2:7:2:7 | a | local_dataflow.rb:2:3:2:7 | ... = ... |
+| local_dataflow.rb:2:7:2:7 | a | local_dataflow.rb:2:3:2:7 | ... = ... |
+| local_dataflow.rb:2:7:2:7 | a | local_dataflow.rb:3:10:3:10 | a |
+| local_dataflow.rb:3:7:3:14 | (...; ...) | local_dataflow.rb:3:3:3:14 | ... = ... |
+| local_dataflow.rb:3:10:3:10 | [post] a | local_dataflow.rb:4:11:4:11 | a |
+| local_dataflow.rb:3:10:3:10 | a | local_dataflow.rb:4:11:4:11 | a |
+| local_dataflow.rb:3:13:3:13 | b | local_dataflow.rb:3:7:3:14 | (...; ...) |
+| local_dataflow.rb:3:13:3:13 | b | local_dataflow.rb:6:13:6:13 | b |
+| local_dataflow.rb:4:7:4:11 | ... = ... | local_dataflow.rb:4:3:4:11 | ... = ... |
+| local_dataflow.rb:4:11:4:11 | a | local_dataflow.rb:4:7:4:11 | ... = ... |
+| local_dataflow.rb:4:11:4:11 | a | local_dataflow.rb:5:12:5:12 | a |
+| local_dataflow.rb:5:7:5:13 | (... = ...) | local_dataflow.rb:5:3:5:13 | ... = ... |
+| local_dataflow.rb:5:8:5:12 | ... = ... | local_dataflow.rb:5:7:5:13 | (... = ...) |
+| local_dataflow.rb:5:12:5:12 | a | local_dataflow.rb:5:8:5:12 | ... = ... |
+| local_dataflow.rb:5:12:5:12 | a | local_dataflow.rb:6:8:6:8 | a |
+| local_dataflow.rb:6:7:6:14 | (... += ...) | local_dataflow.rb:6:3:6:14 | ... = ... |
+| local_dataflow.rb:6:8:6:13 | ... += ... | local_dataflow.rb:6:7:6:14 | (... += ...) |
diff --git a/ql/test/library-tests/dataflow/local/DataflowStep.ql b/ql/test/library-tests/dataflow/local/DataflowStep.ql
new file mode 100644
index 00000000000..38d3366adf2
--- /dev/null
+++ b/ql/test/library-tests/dataflow/local/DataflowStep.ql
@@ -0,0 +1,6 @@
+import ruby
+import codeql_ruby.DataFlow
+
+from DataFlow::Node pred, DataFlow::Node succ
+where DataFlow::localFlowStep(pred, succ)
+select pred, succ
diff --git a/ql/test/library-tests/dataflow/local/local_dataflow.rb b/ql/test/library-tests/dataflow/local/local_dataflow.rb
new file mode 100644
index 00000000000..5ba6d140bf2
--- /dev/null
+++ b/ql/test/library-tests/dataflow/local/local_dataflow.rb
@@ -0,0 +1,7 @@
+def foo(a)
+  b = a
+  c = (p a; b)
+  d = c = a
+  d = (c = a)
+  e = (a += b)
+end