hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 17:25:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Formatting, capitalization, and typos

Browse Source 
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com>
This commit is contained in:
Edward Minnix III
2023-01-23 10:41:50 -05:00
committed by Ed Minnix
parent b606271a61
commit 839b88a4bc
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
java/ql/src/Security/CWE/CWE-094/ArbitraryAPKInstallation.ql
View File

@@ -61,10 +61,10 @@ class UriConstructorMethod extends Method {
/**
* A dataflow source representing the URIs which an APK not controlled by the
* application may come from. Incuding external storage and web URLs.
* application may come from. Including external storage and web URLs.
*/
class ExternalAPKSource extends DataFlow::Node {
ExternalAPKSource() {
class ExternalApkSource extends DataFlow::Node {
ExternalApkSource() {
sourceNode(this, "android-external-storage-dir") or
this.asExpr().(MethodAccess).getMethod() instanceof UriConstructorMethod or
this.asExpr().(StringLiteral).getValue().matches(["file://%", "http://%", "https://%"])
@@ -75,10 +75,10 @@ class ExternalAPKSource extends DataFlow::Node {
* A dataflow configuration for flow from an external source of an APK to the
* `setData[AndType][AndNormalize]` method of an intent.
*/
class APKConfiguration extends DataFlow::Configuration {
APKConfiguration() { this = "APKConfiguration" }
class ApkConfiguration extends DataFlow::Configuration {
ApkConfiguration() { this = "ApkConfiguration" }
override predicate isSource(DataFlow::Node node) { node instanceof ExternalAPKSource }
override predicate isSource(DataFlow::Node node) { node instanceof ExternalApkSource }
override predicate isSink(DataFlow::Node node) {
exists(MethodAccess ma |
@@ -124,6 +124,6 @@ private class PackageArchiveMimeTypeConfiguration extends TaintTracking2::Config
}
}
from DataFlow::PathNode source, DataFlow::PathNode sink, APKConfiguration config
from DataFlow::PathNode source, DataFlow::PathNode sink, ApkConfiguration config
where config.hasFlowPath(source, sink)
select sink.getNode(), source, sink, "Arbitrary Android APK installation."