hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused args

Browse Source
This commit is contained in:
Pavel Avgustinov
2019-07-11 16:51:30 +01:00
committed by Jonas Jensen
parent b1632587bc
commit 835e495e7c
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cpp/ql/src/semmle/code/cpp/dataflow/internal/FlowVar.qll
View File

@@ -98,15 +98,15 @@ class FlowVar extends TFlowVar {
*/
private module PartialDefinitions {
private newtype TPartialDefinition =
TExplicitFieldStoreQualifier(Expr qualifier, FieldAccess fa, Expr assignment, Expr assigned) {
isInstanceFieldWrite(fa, assignment, assigned) and qualifier = fa.getQualifier()
TExplicitFieldStoreQualifier(Expr qualifier, FieldAccess fa) {
isInstanceFieldWrite(fa) and qualifier = fa.getQualifier()
} or
TExplicitCallQualifier(Expr qualifier, Call call) { qualifier = call.getQualifier() } or
TReferenceArgument(Expr arg, Call call, int i) { isReferenceOrPointerArg(arg, call, i) }
private predicate isInstanceFieldWrite(FieldAccess fa, Expr assignment, Expr assigned) {
private predicate isInstanceFieldWrite(FieldAccess fa) {
not fa.getTarget().isStatic() and
assignmentLikeOperation(assignment, fa.getTarget(), fa, assigned)
assignmentLikeOperation(_, fa.getTarget(), fa, _)
}
private predicate isReferenceOrPointerArg(Expr arg, Call call, int i) {
@@ -120,7 +120,7 @@ private module PartialDefinitions {
Expr definedExpr;
PartialDefinition() {
this = TExplicitFieldStoreQualifier(definedExpr, _, _, _) or
this = TExplicitFieldStoreQualifier(definedExpr, _) or
this = TExplicitCallQualifier(definedExpr, _) or
this = TReferenceArgument(definedExpr, _, _)
}