From 8a0e202b63ecc6af076dd6980814476ff0baf516 Mon Sep 17 00:00:00 2001 From: Geoffrey White <40627776+geoffw0@users.noreply.github.com> Date: Tue, 19 Sep 2023 15:18:03 +0100 Subject: [PATCH 1/2] CPP: Fix typos. --- .../lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll index 66aac6a81e1..7e5d1a6b0e5 100644 --- a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll +++ b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll @@ -1069,11 +1069,11 @@ private module GetConvertedResultExpression { /** * Gets the expression that should be returned as the result expression from `instr`. * - * Note that this predicate may return multiple results in cases where a conversion belond to a + * Note that this predicate may return multiple results in cases where a conversion belongs to a * different AST element than its operand. */ Expr getConvertedResultExpression(Instruction instr, int n) { - // Only fully converted instructions has a result for `asConvertedExpr` + // Only fully converted instructions have a result for `asConvertedExpr` not conversionFlow(unique( | | getAUse(instr)), _, false, false) and result = getConvertedResultExpressionImpl(instr) and n = 0 From 935b7600ca46a8cba9f8b129a22b4a23a91d68e2 Mon Sep 17 00:00:00 2001 From: Geoffrey White <40627776+geoffw0@users.noreply.github.com> Date: Tue, 19 Sep 2023 15:19:00 +0100 Subject: [PATCH 2/2] Swift: Fix typos. --- .../ql/lib/codeql/swift/security/CleartextLoggingExtensions.qll | 2 +- .../swift/security/CleartextStorageDatabaseExtensions.qll | 2 +- .../swift/security/CleartextStoragePreferencesExtensions.qll | 2 +- .../codeql/swift/security/CleartextTransmissionExtensions.qll | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/swift/ql/lib/codeql/swift/security/CleartextLoggingExtensions.qll b/swift/ql/lib/codeql/swift/security/CleartextLoggingExtensions.qll index 9d630221d94..e329b8876e3 100644 --- a/swift/ql/lib/codeql/swift/security/CleartextLoggingExtensions.qll +++ b/swift/ql/lib/codeql/swift/security/CleartextLoggingExtensions.qll @@ -30,7 +30,7 @@ private class DefaultCleartextLoggingSink extends CleartextLoggingSink { } /** - * An barrier for cleartext logging vulnerabilities. + * A barrier for cleartext logging vulnerabilities. * - encryption; encrypted values are not cleartext. * - booleans; these are more likely to be settings, rather than actual sensitive data. */ diff --git a/swift/ql/lib/codeql/swift/security/CleartextStorageDatabaseExtensions.qll b/swift/ql/lib/codeql/swift/security/CleartextStorageDatabaseExtensions.qll index cb7e8c53ec8..77baa2e7e2e 100644 --- a/swift/ql/lib/codeql/swift/security/CleartextStorageDatabaseExtensions.qll +++ b/swift/ql/lib/codeql/swift/security/CleartextStorageDatabaseExtensions.qll @@ -114,7 +114,7 @@ private class CleartextStorageDatabaseSinks extends SinkModelCsv { } /** - * An barrier for cleartext database storage vulnerabilities. + * A barrier for cleartext database storage vulnerabilities. * - encryption; encrypted values are not cleartext. * - booleans; these are more likely to be settings, rather than actual sensitive data. */ diff --git a/swift/ql/lib/codeql/swift/security/CleartextStoragePreferencesExtensions.qll b/swift/ql/lib/codeql/swift/security/CleartextStoragePreferencesExtensions.qll index 26f3c02fb1f..99080c3ff73 100644 --- a/swift/ql/lib/codeql/swift/security/CleartextStoragePreferencesExtensions.qll +++ b/swift/ql/lib/codeql/swift/security/CleartextStoragePreferencesExtensions.qll @@ -78,7 +78,7 @@ private class NSUserDefaultsControllerStore extends CleartextStoragePreferencesS } /** - * An barrier for cleartext preferences storage vulnerabilities. + * A barrier for cleartext preferences storage vulnerabilities. * - encryption; encrypted values are not cleartext. * - booleans; these are more likely to be settings, rather than actual sensitive data. */ diff --git a/swift/ql/lib/codeql/swift/security/CleartextTransmissionExtensions.qll b/swift/ql/lib/codeql/swift/security/CleartextTransmissionExtensions.qll index 835c5952ec5..752dc278cce 100644 --- a/swift/ql/lib/codeql/swift/security/CleartextTransmissionExtensions.qll +++ b/swift/ql/lib/codeql/swift/security/CleartextTransmissionExtensions.qll @@ -49,7 +49,7 @@ private class AlamofireTransmittedSink extends CleartextTransmissionSink { } /** - * An barrier for cleartext transmission vulnerabilities. + * A barrier for cleartext transmission vulnerabilities. * - encryption; encrypted values are not cleartext. * - booleans; these are more likely to be settings, rather than actual sensitive data. */