hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-05 05:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove deprecated InlineExpectationsTest class-based API

Browse Source
This commit is contained in:
Jeroen Ketema
2024-12-03 15:54:07 +01:00
parent 06b1d8e448
commit 8271ad60c1
2 changed files with 4 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shared/util/change-notes/2024-12-03-remove-deprected-inline-expecation-test-classes.md Normal file
View File

@@ -0,0 +1,4 @@
---
category: breaking
---
* Deleted the old deprecated inline expectation test API that was based on the `InlineExpectationsTest` class.

49
shared/util/codeql/util/test/InlineExpectationsTest.qll
View File

@@ -500,55 +500,6 @@ module Make<InlineExpectationsTestSig Impl> {
}
}
deprecated private module LegacyImpl implements TestSig {
string getARelevantTag() { result = any(InlineExpectationsTest t).getARelevantTag() }
predicate hasActualResult(Impl::Location location, string element, string tag, string value) {
any(InlineExpectationsTest t).hasActualResult(location, element, tag, value)
}
predicate hasOptionalResult(Impl::Location location, string element, string tag, string value) {
any(InlineExpectationsTest t).hasOptionalResult(location, element, tag, value)
}
}
/**
* DEPRECATED: Use the InlineExpectationsTest module.
*
* The base class for tests with inline expectations. The test extends this class to provide the actual
* results of the query, which are then compared with the expected results in comments to produce a
* list of failure messages that point out where the actual results differ from the expected
* results.
*/
abstract deprecated class InlineExpectationsTest extends string {
bindingset[this]
InlineExpectationsTest() { any() }
abstract string getARelevantTag();
abstract predicate hasActualResult(
Impl::Location location, string element, string tag, string value
);
predicate hasOptionalResult(Impl::Location location, string element, string tag, string value) {
none()
}
}
deprecated import MakeTest<LegacyImpl> as LegacyTest
deprecated query predicate failures = LegacyTest::testFailures/2;
deprecated class ActualResult = LegacyTest::ActualTestResult;
deprecated class GoodExpectation = LegacyTest::GoodTestExpectation;
deprecated class FalsePositiveExpectation = LegacyTest::FalsePositiveTestExpectation;
deprecated class FalseNegativeExpectation = LegacyTest::FalseNegativeTestExpectation;
deprecated class InvalidExpectation = LegacyTest::InvalidTestExpectation;
/**
* Holds if the expectation `tag=value` is found in one or more expectation comments.
*