hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 02:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Nit: fix qhelp

Browse Source
This commit is contained in:
SpaceWhite
2020-03-12 20:25:23 +09:00
parent 5e912cbf8e
commit 822bfcd36c
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/ql/src/experimental/CWE-094/ScriptEngine.qhelp
View File

@@ -4,16 +4,16 @@
<qhelp>
<overview>
<p> The ScriptEngine api is available since the release of Java 6.
It allows application to interact with script written in language such as JavaScript.</p>
<p>The ScriptEngine API has been available since the release of Java 6.
It allows applications to interact with scripts written in languages such as JavaScript.</p>
</overview>
<recommendation>
Use "Cloudbees Rhino Sandbox" or sandboxing with SecurityManager or use <a href="https://www.graalvm.org/">graalvm</a> instead
<p>Use "Cloudbees Rhino Sandbox" or sandboxing with SecurityManager or use <a href="https://www.graalvm.org/">graalvm</a> instead.</p>
</recommendation>
<example>
The following code could executes random JavaScript code
<p>The following code could execute random JavaScript code</p>
<sample src="ScriptEngine.java" />
</example>

6
java/ql/src/experimental/CWE-094/ScriptEngine.ql
View File

@@ -1,6 +1,6 @@
/**
* @name Script engine eval
* @description Malicious javascript code could caused arbitrary command execution on OS level
* @name ScriptEngine evaluation
* @description Malicious Javascript code could cause arbitrary command execution at the OS level
* @kind path-problem
* @problem.severity error
* @precision high
@@ -47,5 +47,5 @@ class ScriptEngineConfiguration extends TaintTracking::Configuration {
from DataFlow::PathNode source, DataFlow::PathNode sink, ScriptEngineConfiguration conf
where conf.hasFlowPath(source, sink)
select sink.getNode().(ScriptEngineSink).getMethodAccess(), source, sink, "Script engine eval $@.",
select sink.getNode().(ScriptEngineSink).getMethodAccess(), source, sink, "ScriptEngine eval $@.",
source.getNode(), "user input"