mirror of
https://github.com/github/codeql.git
synced 2026-03-30 20:28:15 +02:00
JS: Address PR review comments
- Fix misplaced semicolons in test files (was inside comment, moved before it) - Update QLdoc comments to reference new browser source kind names - Update docs to list browser source kinds and fix outdated 'only remote' note Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
@@ -85,16 +85,16 @@ class ClientSideRemoteFlowKind extends string {
|
||||
*/
|
||||
predicate isUrl() { this = "browser-url" }
|
||||
|
||||
/** Holds if this is the `query` or `fragment` kind. */
|
||||
/** Holds if this is the `browser-url-query` or `browser-url-fragment` kind. */
|
||||
predicate isQueryOrFragment() { this.isQuery() or this.isFragment() }
|
||||
|
||||
/** Holds if this is the `path`, `query`, or `fragment` kind. */
|
||||
/** Holds if this is the `browser-url-path`, `browser-url-query`, or `browser-url-fragment` kind. */
|
||||
predicate isPathOrQueryOrFragment() { this.isPath() or this.isQuery() or this.isFragment() }
|
||||
|
||||
/** Holds if this is the `path` or `url` kind. */
|
||||
/** Holds if this is the `browser-url-path` or `browser-url` kind. */
|
||||
predicate isPathOrUrl() { this.isPath() or this.isUrl() }
|
||||
|
||||
/** Holds if this is the `name` kind, describing sources derived from the window name, such as `window.name`. */
|
||||
/** Holds if this is the `browser-window-name` kind, describing sources derived from the window name, such as `window.name`. */
|
||||
predicate isWindowName() { this = "browser-window-name" }
|
||||
|
||||
/**
|
||||
|
||||
@@ -24,5 +24,5 @@ export function MyComponent() {
|
||||
request(window.location.href + '?q=123');
|
||||
|
||||
const custom = require('testlib').getBrowserSource(); // $ Source[js/client-side-request-forgery]
|
||||
request(custom) // $ Alert[js/client-side-request-forgery];
|
||||
request(custom); // $ Alert[js/client-side-request-forgery]
|
||||
}
|
||||
|
||||
@@ -148,4 +148,4 @@ var server2 = http.createServer(function (req, res) {
|
||||
});
|
||||
|
||||
const custom = require('testlib').getServerSource(); // $ Source[js/request-forgery]
|
||||
request(custom) // $ Alert[js/request-forgery];
|
||||
request(custom); // $ Alert[js/request-forgery]
|
||||
|
||||
Reference in New Issue
Block a user