hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 20:25:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Refactored SortTaintStep to ArrayInPlaceManipulationTaintStep to support both sort and reverse functions. Fixed newly added test case. from 8026a99db7

Browse Source
This commit is contained in:
Napalys
2024-11-08 12:30:39 +01:00
parent 1c298f0231
commit 81bc7cd19f
3 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
javascript/ql/lib/semmle/javascript/Arrays.qll
View File

@@ -446,12 +446,12 @@ private module ArrayLibraries {
}
/**
* A taint propagating data flow edge arising from sorting.
* A taint propagating data flow edge arising from in-place array manipulation operations.
*/
private class SortTaintStep extends TaintTracking::SharedTaintStep {
private class ArrayInPlaceManipulationTaintStep extends TaintTracking::SharedTaintStep {
override predicate heapStep(DataFlow::Node pred, DataFlow::Node succ) {
exists(DataFlow::MethodCallNode call |
call.getMethodName() = "sort" and
call.getMethodName() in ["sort", "reverse"] and
pred = call.getReceiver() and
succ = call
)