From 813ce7d3f880b48a4dfbd942fa681f42e3f456fe Mon Sep 17 00:00:00 2001 From: Tamas Vajk Date: Tue, 8 Jul 2025 11:03:32 +0200 Subject: [PATCH] Rename query --- .../java-code-quality-extended.qls.expected | 2 +- .../java/query-suite/java-code-quality.qls.expected | 2 +- ...d => IgnoredSerializationMembersOfRecordClass.md} | 0 ...l => IgnoredSerializationMembersOfRecordClass.ql} | 6 +++--- ...gnoredSerializationMembersOfRecordClass.expected} | 12 ++++++------ .../IgnoredSerializationMembersOfRecordClass.qlref | 2 ++ .../Test.java | 0 .../options | 0 .../UselessMembersOfTheRecordsClass.qlref | 2 -- 9 files changed, 13 insertions(+), 13 deletions(-) rename java/ql/src/Violations of Best Practice/Records/{UselessMembersOfTheRecordsClass.md => IgnoredSerializationMembersOfRecordClass.md} (100%) rename java/ql/src/Violations of Best Practice/Records/{UselessMembersOfTheRecordsClass.ql => IgnoredSerializationMembersOfRecordClass.ql} (76%) rename java/ql/test/query-tests/{UselessMembersOfTheRecordsClass/UselessMembersOfTheRecordsClass.expected => IgnoredSerializationMembersOfRecordClass/IgnoredSerializationMembersOfRecordClass.expected} (51%) create mode 100644 java/ql/test/query-tests/IgnoredSerializationMembersOfRecordClass/IgnoredSerializationMembersOfRecordClass.qlref rename java/ql/test/query-tests/{UselessMembersOfTheRecordsClass => IgnoredSerializationMembersOfRecordClass}/Test.java (100%) rename java/ql/test/query-tests/{UselessMembersOfTheRecordsClass => IgnoredSerializationMembersOfRecordClass}/options (100%) delete mode 100644 java/ql/test/query-tests/UselessMembersOfTheRecordsClass/UselessMembersOfTheRecordsClass.qlref diff --git a/java/ql/integration-tests/java/query-suite/java-code-quality-extended.qls.expected b/java/ql/integration-tests/java/query-suite/java-code-quality-extended.qls.expected index 00b8a91fb57..7a76c4ad911 100644 --- a/java/ql/integration-tests/java/query-suite/java-code-quality-extended.qls.expected +++ b/java/ql/integration-tests/java/query-suite/java-code-quality-extended.qls.expected @@ -77,7 +77,7 @@ ql/java/ql/src/Violations of Best Practice/Naming Conventions/ConfusingMethodNam ql/java/ql/src/Violations of Best Practice/Naming Conventions/ConfusingOverloading.ql ql/java/ql/src/Violations of Best Practice/Naming Conventions/LocalShadowsFieldConfusing.ql ql/java/ql/src/Violations of Best Practice/Naming Conventions/SameNameAsSuper.ql -ql/java/ql/src/Violations of Best Practice/Records/UselessMembersOfTheRecordsClass.ql +ql/java/ql/src/Violations of Best Practice/Records/IgnoredSerializationMembersOfRecordClass.ql ql/java/ql/src/Violations of Best Practice/Undesirable Calls/CallsToStringToString.ql ql/java/ql/src/Violations of Best Practice/Undesirable Calls/DefaultToString.ql ql/java/ql/src/Violations of Best Practice/Undesirable Calls/DoNotCallFinalize.ql diff --git a/java/ql/integration-tests/java/query-suite/java-code-quality.qls.expected b/java/ql/integration-tests/java/query-suite/java-code-quality.qls.expected index df6ec8fab81..c9a36f8fe13 100644 --- a/java/ql/integration-tests/java/query-suite/java-code-quality.qls.expected +++ b/java/ql/integration-tests/java/query-suite/java-code-quality.qls.expected @@ -75,7 +75,7 @@ ql/java/ql/src/Violations of Best Practice/Naming Conventions/ConfusingMethodNam ql/java/ql/src/Violations of Best Practice/Naming Conventions/ConfusingOverloading.ql ql/java/ql/src/Violations of Best Practice/Naming Conventions/LocalShadowsFieldConfusing.ql ql/java/ql/src/Violations of Best Practice/Naming Conventions/SameNameAsSuper.ql -ql/java/ql/src/Violations of Best Practice/Records/UselessMembersOfTheRecordsClass.ql +ql/java/ql/src/Violations of Best Practice/Records/IgnoredSerializationMembersOfRecordClass.ql ql/java/ql/src/Violations of Best Practice/Undesirable Calls/CallsToStringToString.ql ql/java/ql/src/Violations of Best Practice/Undesirable Calls/DefaultToString.ql ql/java/ql/src/Violations of Best Practice/Undesirable Calls/DoNotCallFinalize.ql diff --git a/java/ql/src/Violations of Best Practice/Records/UselessMembersOfTheRecordsClass.md b/java/ql/src/Violations of Best Practice/Records/IgnoredSerializationMembersOfRecordClass.md similarity index 100% rename from java/ql/src/Violations of Best Practice/Records/UselessMembersOfTheRecordsClass.md rename to java/ql/src/Violations of Best Practice/Records/IgnoredSerializationMembersOfRecordClass.md diff --git a/java/ql/src/Violations of Best Practice/Records/UselessMembersOfTheRecordsClass.ql b/java/ql/src/Violations of Best Practice/Records/IgnoredSerializationMembersOfRecordClass.ql similarity index 76% rename from java/ql/src/Violations of Best Practice/Records/UselessMembersOfTheRecordsClass.ql rename to java/ql/src/Violations of Best Practice/Records/IgnoredSerializationMembersOfRecordClass.ql index a55b283d6e7..627f4cc669b 100644 --- a/java/ql/src/Violations of Best Practice/Records/UselessMembersOfTheRecordsClass.ql +++ b/java/ql/src/Violations of Best Practice/Records/IgnoredSerializationMembersOfRecordClass.ql @@ -1,6 +1,6 @@ /** - * @id java/useless-member-of-the-record-class - * @name Useless serialization member of record class + * @id java/ignored-serialization-member-of-record-class + * @name Ignored serialization member of record class * @description Using certain members of a record class during serialization will result in * those members being ignored. * @previous-id java/useless-members-of-the-records-class @@ -21,4 +21,4 @@ where "writeObject", "readObject", "readObjectNoData", "writeExternal", "readExternal", "serialPersistentFields" ]) -select m, "Useless serialization member found in record class $@.", record, record.getName() +select m, "Ignored serialization member found in record class $@.", record, record.getName() diff --git a/java/ql/test/query-tests/UselessMembersOfTheRecordsClass/UselessMembersOfTheRecordsClass.expected b/java/ql/test/query-tests/IgnoredSerializationMembersOfRecordClass/IgnoredSerializationMembersOfRecordClass.expected similarity index 51% rename from java/ql/test/query-tests/UselessMembersOfTheRecordsClass/UselessMembersOfTheRecordsClass.expected rename to java/ql/test/query-tests/IgnoredSerializationMembersOfRecordClass/IgnoredSerializationMembersOfRecordClass.expected index 27195b3f508..6bee2382774 100644 --- a/java/ql/test/query-tests/UselessMembersOfTheRecordsClass/UselessMembersOfTheRecordsClass.expected +++ b/java/ql/test/query-tests/IgnoredSerializationMembersOfRecordClass/IgnoredSerializationMembersOfRecordClass.expected @@ -1,6 +1,6 @@ -| Test.java:7:46:7:67 | serialPersistentFields | Useless serialization member found in record class $@. | Test.java:4:12:4:13 | T1 | T1 | -| Test.java:10:18:10:28 | writeObject | Useless serialization member found in record class $@. | Test.java:4:12:4:13 | T1 | T1 | -| Test.java:13:18:13:27 | readObject | Useless serialization member found in record class $@. | Test.java:4:12:4:13 | T1 | T1 | -| Test.java:16:18:16:33 | readObjectNoData | Useless serialization member found in record class $@. | Test.java:4:12:4:13 | T1 | T1 | -| Test.java:24:17:24:29 | writeExternal | Useless serialization member found in record class $@. | Test.java:21:12:21:13 | T2 | T2 | -| Test.java:28:17:28:28 | readExternal | Useless serialization member found in record class $@. | Test.java:21:12:21:13 | T2 | T2 | +| Test.java:7:46:7:67 | serialPersistentFields | Ignored serialization member found in record class $@. | Test.java:4:12:4:13 | T1 | T1 | +| Test.java:10:18:10:28 | writeObject | Ignored serialization member found in record class $@. | Test.java:4:12:4:13 | T1 | T1 | +| Test.java:13:18:13:27 | readObject | Ignored serialization member found in record class $@. | Test.java:4:12:4:13 | T1 | T1 | +| Test.java:16:18:16:33 | readObjectNoData | Ignored serialization member found in record class $@. | Test.java:4:12:4:13 | T1 | T1 | +| Test.java:24:17:24:29 | writeExternal | Ignored serialization member found in record class $@. | Test.java:21:12:21:13 | T2 | T2 | +| Test.java:28:17:28:28 | readExternal | Ignored serialization member found in record class $@. | Test.java:21:12:21:13 | T2 | T2 | diff --git a/java/ql/test/query-tests/IgnoredSerializationMembersOfRecordClass/IgnoredSerializationMembersOfRecordClass.qlref b/java/ql/test/query-tests/IgnoredSerializationMembersOfRecordClass/IgnoredSerializationMembersOfRecordClass.qlref new file mode 100644 index 00000000000..fa7814867df --- /dev/null +++ b/java/ql/test/query-tests/IgnoredSerializationMembersOfRecordClass/IgnoredSerializationMembersOfRecordClass.qlref @@ -0,0 +1,2 @@ +query: Violations of Best Practice/Records/IgnoredSerializationMembersOfRecordClass.ql +postprocess: utils/test/InlineExpectationsTestQuery.ql diff --git a/java/ql/test/query-tests/UselessMembersOfTheRecordsClass/Test.java b/java/ql/test/query-tests/IgnoredSerializationMembersOfRecordClass/Test.java similarity index 100% rename from java/ql/test/query-tests/UselessMembersOfTheRecordsClass/Test.java rename to java/ql/test/query-tests/IgnoredSerializationMembersOfRecordClass/Test.java diff --git a/java/ql/test/query-tests/UselessMembersOfTheRecordsClass/options b/java/ql/test/query-tests/IgnoredSerializationMembersOfRecordClass/options similarity index 100% rename from java/ql/test/query-tests/UselessMembersOfTheRecordsClass/options rename to java/ql/test/query-tests/IgnoredSerializationMembersOfRecordClass/options diff --git a/java/ql/test/query-tests/UselessMembersOfTheRecordsClass/UselessMembersOfTheRecordsClass.qlref b/java/ql/test/query-tests/UselessMembersOfTheRecordsClass/UselessMembersOfTheRecordsClass.qlref deleted file mode 100644 index 5b4ab63ba4b..00000000000 --- a/java/ql/test/query-tests/UselessMembersOfTheRecordsClass/UselessMembersOfTheRecordsClass.qlref +++ /dev/null @@ -1,2 +0,0 @@ -query: Violations of Best Practice/Records/UselessMembersOfTheRecordsClass.ql -postprocess: utils/test/InlineExpectationsTestQuery.ql