hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-22 15:25:18 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: Simplify mock call location check using getEnclosingCallable

Browse Source
This commit is contained in:
Napalys Klicius
2025-08-26 09:44:00 +00:00
parent 1abb8ad54a
commit 8017fae297
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/src/Likely Bugs/Frameworks/JUnit/ExcessivePublicMethodMocking.ql
View File

@@ -65,7 +65,7 @@ class MockitoMockingMethodCall extends MethodCall {
from JUnit4TestMethod testMethod, ClassOrInterface mockedClassOrInterface
where
exists(MockitoMockCall mockCall |
mockCall.getParent+() = testMethod.getBody().getAStmt() and
mockCall.getEnclosingCallable() = testMethod and
mockedClassOrInterface = mockCall.getMockedType() and
// Only flag classes with multiple public methods (2 or more)
strictcount(Method m | m = mockedClassOrInterface.getAMethod() and m.isPublic()) > 1 and