hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 03:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments

Browse Source
This commit is contained in:
Tom Hvitved
2022-01-11 13:29:19 +01:00
parent 2de892bfd8
commit 7fd8d6dd30
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
python/ql/lib/semmle/python/pointsto/MRO.qll
View File

@@ -173,7 +173,7 @@ class ClassList extends TClassList {
this.duplicate(n) and result = this.deduplicate(n + 1)
or
exists(ClassObjectInternal cls, ClassList tail |
deduplicateCons(n, cls, tail) and
this.deduplicateCons(n, cls, tail) and
result = Cons(cls, tail)
)
}
@@ -281,7 +281,7 @@ private class ClassListList extends TClassListList {
removed_head = this.removedClassPartsCons1(cls, removed_tail, n).removeHead(cls)
}
pragma[noinline]
pragma[nomagic]
predicate removedClassPartsCons0(ClassObjectInternal cls, ClassListList removed_tail, int n) {
exists(ClassList prev_head, ClassListList prev_tail |
this.removedClassParts(cls, prev_head, prev_tail, n + 1) and
@@ -289,9 +289,9 @@ private class ClassListList extends TClassListList {
)
}
pragma[noinline]
pragma[nomagic]
ClassList removedClassPartsCons1(ClassObjectInternal cls, ClassListList removed_tail, int n) {
removedClassPartsCons0(cls, removed_tail, n) and
this.removedClassPartsCons0(cls, removed_tail, n) and
result = this.getItem(n)
}
@@ -310,7 +310,7 @@ private class ClassListList extends TClassListList {
cl = this.getItem(n) and
j = cl.length()
or
legalMergeCandidateNonEmpty(cls, n, cl, j + 1) and
this.legalMergeCandidateNonEmpty(cls, n, cl, j + 1) and
j >= 1 and
cls != cl.getItem(j)
}
@@ -321,14 +321,14 @@ private class ClassListList extends TClassListList {
this.legalMergeCandidate(cls, n + 1) and
this.getItem(n) = Empty()
or
legalMergeCandidateNonEmpty(cls, n, _, 1)
this.legalMergeCandidateNonEmpty(cls, n, _, 1)
}
predicate legalMergeCandidate(ClassObjectInternal cls) { this.legalMergeCandidate(cls, 0) }
predicate illegalMergeCandidate(ClassObjectInternal cls) {
exists(ClassList cl, int j |
legalMergeCandidateNonEmpty(cls, _, cl, j + 1) and
this.legalMergeCandidateNonEmpty(cls, _, cl, j + 1) and
j >= 1 and
cls = cl.getItem(j)
)