hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 03:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Rename to upward navigation

Browse Source
This commit is contained in:
Asger F
2019-10-25 13:07:07 +01:00
parent 5636d42c13
commit 7ed31baeea
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
javascript/ql/src/semmle/javascript/Concepts.qll
View File

@@ -38,12 +38,12 @@ abstract class FileSystemAccess extends DataFlow::Node {
DataFlow::Node getRootPathArgument() { none() }
/**
* Holds if this file system access will reject paths containing path traversal
* Holds if this file system access will reject paths containing upward navigation
* segments (`../`).
*
* `argument` should refer to the relevant path argument or root path argument.
*/
predicate isPathTraversalRejected(DataFlow::Node argument) { none() }
predicate isUpwardNavigationRejected(DataFlow::Node argument) { none() }
}
/**

2
javascript/ql/src/semmle/javascript/frameworks/Express.qll
View File

@@ -840,7 +840,7 @@ module Express {
result = this.(DataFlow::CallNode).getOptionArgument(1, "root")
}
override predicate isPathTraversalRejected(DataFlow::Node argument) {
override predicate isUpwardNavigationRejected(DataFlow::Node argument) {
argument = getAPathArgument()
}
}

8
javascript/ql/src/semmle/javascript/security/dataflow/TaintedPathCustomizations.qll
View File

@@ -393,11 +393,11 @@ module TaintedPath {
}
/**
* A path argument to a file system access, which disallows path traversal.
* A path argument to a file system access, which disallows upward navigation.
*/
private class FsPathSinkWithoutPathTraversal extends FsPathSink {
FsPathSinkWithoutPathTraversal() {
fileSystemAccess.isPathTraversalRejected(this)
private class FsPathSinkWithoutUpwardNavigation extends FsPathSink {
FsPathSinkWithoutUpwardNavigation() {
fileSystemAccess.isUpwardNavigationRejected(this)
}
override DataFlow::FlowLabel getAFlowLabel() {