hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-18 16:03:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: Restrict type-tracking content to only be precise

Browse Source 
At least for now :)
This commit is contained in:
Rasmus Wriedt Larsen
2024-03-15 10:24:57 +01:00
parent 6babb2ff90
commit 7eb4419342
2 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
python/ql/lib/semmle/python/dataflow/new/internal/TypeTrackingImpl.qll
View File

@@ -102,7 +102,21 @@ module TypeTrackingInput implements Shared::TypeTrackingInput {
class LocalSourceNode = DataFlowPublic::LocalSourceNode;
class Content = DataFlowPublic::Content;
class Content extends DataFlowPublic::Content {
Content() {
// TODO: for now, it's not 100% clear if should support non-precise content in
// type-tracking, or if it will lead to bad results. We start with only allowing
// precise content, which should always be a good improvement! It also simplifies
// the process of examining new results from non-precise content steps in the
// future, since you will _only_ have to look over the results from the new
// non-precise steps.
this instanceof DataFlowPublic::AttributeContent
or
this instanceof DataFlowPublic::DictionaryElementContent
or
this instanceof DataFlowPublic::TupleElementContent
}
}
/**
* A label to use for `WithContent` and `WithoutContent` steps, restricting