hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 01:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add QLdoc and fix Compiler Errors in Tests

Browse Source
This commit is contained in:
Jonathan Leitschuh
2021-04-08 10:19:38 -04:00
parent cb30385684
commit 7e514e9ef9
2 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/ql/src/Security/CWE/CWE-200/TempDirUtils.qll
View File

@@ -1,3 +1,6 @@
/**
* Provides classes and predicates for reasoning about temporary file/directory creations.
*/
import java
import semmle.code.java.dataflow.FlowSources

18
java/ql/test/query-tests/security/CWE-200/semmle/tests/Test.java
View File

@@ -11,35 +11,35 @@ import java.util.EnumSet;
public class Test {
void vulnerableFileCreateTempFile() {
void vulnerableFileCreateTempFile() throws IOException {
File temp = File.createTempFile("random", "file");
}
void vulnerableFileCreateTempFileNull() {
void vulnerableFileCreateTempFileNull() throws IOException {
File temp = File.createTempFile("random", "file", null);
}
void vulnerableFileCreateTempFileTainted() {
void vulnerableFileCreateTempFileTainted() throws IOException {
File tempDir = new File(System.getProperty("java.io.tmpdir"));
File temp = File.createTempFile("random", "file", tempDir);
}
void vulnerableFileCreateTempFileChildTainted() {
void vulnerableFileCreateTempFileChildTainted() throws IOException {
File tempDirChild = new File(new File(System.getProperty("java.io.tmpdir")), "/child");
File temp = File.createTempFile("random", "file", tempDirChild);
}
void vulnerableFileCreateTempFileCanonical() {
void vulnerableFileCreateTempFileCanonical() throws IOException {
File tempDir = new File(System.getProperty("java.io.tmpdir")).getCanonicalFile();
File temp = File.createTempFile("random", "file", tempDir);
}
void vulnerableFileCreateTempFileAbsolute() {
void vulnerableFileCreateTempFileAbsolute() throws IOException {
File tempDir = new File(System.getProperty("java.io.tmpdir")).getAbsoluteFile();
File temp = File.createTempFile("random", "file", tempDir);
}
void safeFileCreateTempFileTainted() {
void safeFileCreateTempFileTainted() throws IOException {
/* Creating a temporary directoy in the current user directory is not a vulnerability. */
File currentDirectory = new File(System.getProperty("user.dir"));
File temp = File.createTempFile("random", "file", currentDirectory);
@@ -59,12 +59,12 @@ public class Test {
tempDirChild.mkdirs();
}
void vulnerableFileCreateTempFilesWrite1() {
void vulnerableFileCreateTempFilesWrite1() throws IOException {
File tempDirChild = new File(System.getProperty("java.io.tmpdir"), "/child.txt");
Files.write(tempDirChild.toPath(), Arrays.asList("secret"), StandardCharsets.UTF_8, StandardOpenOption.CREATE);
}
void vulnerableFileCreateTempFilesWrite2() {
void vulnerableFileCreateTempFilesWrite2() throws IOException {
File tempDirChild = new File(System.getProperty("java.io.tmpdir"), "/child.txt");
String secret = "secret";
byte[] byteArrray = secret.getBytes();