hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-22 03:36:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Optimize MissingCheckScanf/bigStep()

Browse Source
This commit is contained in:
Nora Dimitrijević
2022-08-25 17:12:25 +02:00
parent 02772ed20c
commit 7d24d96d80
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
cpp/ql/src/Critical/MissingCheckScanf.ql
View File

@@ -66,16 +66,16 @@ class ScanfOutput extends Expr {
*/ */
Access getAnAccess() { Access getAnAccess() {
exists(Instruction dst | exists(Instruction dst |
this.bigStep(instr) = dst and this.bigStep() = dst and
dst.getAst() = result and dst.getAst() = result and
valueNumber(dst) = valNum valueNumber(dst) = valNum
) )
} }
private Instruction bigStep(Instruction i) { private Instruction bigStep() {
result = this.smallStep(i) result = this.smallStep(instr)
or or
exists(Instruction j | j = this.bigStep(i) | result = this.smallStep(j)) exists(Instruction i | i = this.bigStep() | result = this.smallStep(i))
} }
private Instruction smallStep(Instruction i) { private Instruction smallStep(Instruction i) {