From 7d0d39e019a2d8967aba630850a680d240dbd5d2 Mon Sep 17 00:00:00 2001
From: Ahmed Farid <farid532009@gmail.com>
Date: Wed, 20 Jul 2022 13:05:49 +0100
Subject: [PATCH] Update PossibleTimingAttackAgainstHash.ql

---
 .../CWE-208/PossibleTimingAttackAgainstHash.ql | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)

diff --git a/python/ql/src/experimental/Security/CWE-208/PossibleTimingAttackAgainstHash.ql b/python/ql/src/experimental/Security/CWE-208/PossibleTimingAttackAgainstHash.ql
index 017b45d37b6..1ba71b7ee87 100644
--- a/python/ql/src/experimental/Security/CWE-208/PossibleTimingAttackAgainstHash.ql
+++ b/python/ql/src/experimental/Security/CWE-208/PossibleTimingAttackAgainstHash.ql
@@ -26,23 +26,7 @@ import DataFlow::PathGraph
 class PossibleTimingAttackAgainstHash extends TaintTracking::Configuration {
   PossibleTimingAttackAgainstHash() { this = "PossibleTimingAttackAgainstHash" }
 
-  override predicate isSource(DataFlow::Node source) {
-    source = API::moduleImport("hmac").getMember("digest").getACall() or
-    source =
-      API::moduleImport("hmac")
-          .getMember("new")
-          .getReturn()
-          .getMember(["digest", "hexdigest"])
-          .getACall() or
-    source =
-      API::moduleImport("hashlib")
-          .getMember([
-              "new", "sha1", "sha224", "sha256", "sha384", "sha512", "blake2b", "blake2s", "md5"
-            ])
-          .getReturn()
-          .getMember(["digest", "hexdigest"])
-          .getACall()
-  }
+  override predicate isSource(DataFlow::Node source) { source instanceof ProduceHashCall }
 
   override predicate isSink(DataFlow::Node sink) { sink instanceof CompareSink }
 }