hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 20:25:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #222 from xiemaisi/js/identity-replacement

Browse Source 
JavaScript: Add new query flagging identity replacements.
This commit is contained in:
Esben Sparre Andreasen
2018-09-26 09:25:19 +02:00
committed by GitHub
parent 9c219b958c 0e63ea1b51
commit 7c006d4530
11 changed files with 139 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
javascript/ql/test/query-tests/RegExp/IdentityReplacement/IdentityReplacement.expected Normal file
View File

@@ -0,0 +1,12 @@
| IdentityReplacement.js:1:27:1:30 | /"/g | This replaces '"' with itself. |
| tst.js:1:13:1:16 | "\\\\" | This replaces '\\' with itself. |
| tst.js:2:13:2:18 | /(\\\\)/ | This replaces '\\' with itself. |
| tst.js:3:13:3:17 | /["]/ | This replaces '"' with itself. |
| tst.js:6:13:6:18 | /foo/g | This replaces 'foo' with itself. |
| tst.js:9:13:9:17 | /^\\\\/ | This replaces '\\' with itself. |
| tst.js:10:13:10:17 | /\\\\$/ | This replaces '\\' with itself. |
| tst.js:11:13:11:18 | /\\b\\\\/ | This replaces '\\' with itself. |
| tst.js:12:13:12:18 | /\\B\\\\/ | This replaces '\\' with itself. |
| tst.js:13:13:13:22 | /\\\\(?!\\\\)/ | This replaces '\\' with itself. |
| tst.js:14:13:14:23 | /(?<!\\\\)\\\\/ | This replaces '\\' with itself. |
| tst.js:16:13:16:15 | /^/ | This replaces the empty string with itself. |

1
javascript/ql/test/query-tests/RegExp/IdentityReplacement/IdentityReplacement.js Normal file
View File

@@ -0,0 +1 @@
var escaped = raw.replace(/"/g, '\"');

1
javascript/ql/test/query-tests/RegExp/IdentityReplacement/IdentityReplacement.qlref Normal file
View File

@@ -0,0 +1 @@
RegExp/IdentityReplacement.ql

1
javascript/ql/test/query-tests/RegExp/IdentityReplacement/IdentityReplacementGood.js Normal file
View File

@@ -0,0 +1 @@
var escaped = raw.replace(/"/g, '\\"');

16
javascript/ql/test/query-tests/RegExp/IdentityReplacement/tst.js Normal file
View File

@@ -0,0 +1,16 @@
raw.replace("\\", "\\"); // NOT OK
raw.replace(/(\\)/, "\\"); // NOT OK
raw.replace(/["]/, "\""); // NOT OK
raw.replace("\\", "\\\\"); // OK
raw.replace(/foo/g, 'foo'); // NOT OK
raw.replace(/foo/gi, 'foo'); // OK
raw.replace(/^\\/, "\\"); // NOT OK
raw.replace(/\\$/, "\\"); // NOT OK
raw.replace(/\b\\/, "\\"); // NOT OK
raw.replace(/\B\\/, "\\"); // NOT OK
raw.replace(/\\(?!\\)/, "\\"); // NOT OK
raw.replace(/(?<!\\)\\/, "\\"); // NOT OK
raw.replace(/^/, ""); // NOT OK