JS: Bulk update in UnneededDefensiveProgramming test

The history of updates to this test got messed up so just squashing
into one commit.

Some possible regressions have been accepted, but the query is strangely
opinionated so it's just hard to say what it ought to flag.

javascript/ql/test/query-tests/Expressions/UnneededDefensiveProgramming/global-module-definition.js

@@ -7,5 +7,5 @@ var Mod1;
     var Mod2;
     (function (Mod2) {
         Mod2.p = 42;
-    })(Mod2 || (Mod2 = {})); // $ Alert
+    })(Mod2 || (Mod2 = {}));
 });

javascript/ql/test/query-tests/Expressions/UnneededDefensiveProgramming/module-environment-detection.js

@@ -20,5 +20,5 @@ if (typeof exports !== 'undefined') {
 
 (function(){
     var module;
-    if(typeof module === 'undefined'); // $ Alert
+    if(typeof module === 'undefined'); // $ Alert[js/unneeded-defensive-code]
 });

javascript/ql/test/query-tests/Expressions/UnneededDefensiveProgramming/regression.js

@@ -6,10 +6,10 @@ function getDate() {
 		return null;
 	}
 	console.log(date);
-	return date && date.getTime(); // $ Alert
+	return date && date.getTime(); // $ Alert[js/unneeded-defensive-code]
 }
 
 function isNotNullOrString(obj) {
-  return obj != null && obj != undefined && // $ Alert
-      typeof obj != 'string'; 
+  return obj != null && obj != undefined && // $ Alert[js/unneeded-defensive-code]
+      typeof obj != 'string';
 }

javascript/ql/test/query-tests/Expressions/UnneededDefensiveProgramming/tst.js

@@ -10,95 +10,95 @@
     var o_ = o;
     var x_ = x;
 
-    u_ = u_ || e; // $ Alert
-    n_ = n_ || e; // $ Alert
-    o_ = o_ || e; // $ Alert
+    u_ = u_ || e; // $ MISSING: Alert[js/unneeded-defensive-code]
+    n_ = n_ || e; // $ MISSING: Alert[js/unneeded-defensive-code]
+    o_ = o_ || e; // $ MISSING: Alert[js/unneeded-defensive-code]
     x_ = x_ || e;
 
-    u && u.p; // $ Alert
-    n && n.p; // $ Alert
-    o && o.p; // $ Alert
+    u && u.p; // $ Alert[js/unneeded-defensive-code]
+    n && n.p; // $ Alert[js/unneeded-defensive-code]
+    o && o.p; // $ Alert[js/unneeded-defensive-code]
     x && x.p;
 
-    u && u(); // $ Alert
-    n && n(); // $ Alert
-    o && o(); // $ Alert
+    u && u(); // $ Alert[js/unneeded-defensive-code]
+    n && n(); // $ Alert[js/unneeded-defensive-code]
+    o && o(); // $ Alert[js/unneeded-defensive-code]
     x && x();
 
-    !u || u.p; // $ Alert
-    !n || n.p; // $ Alert
-    !o || o.p; // $ Alert
+    !u || u.p; // $ Alert[js/unneeded-defensive-code]
+    !n || n.p; // $ Alert[js/unneeded-defensive-code]
+    !o || o.p; // $ Alert[js/unneeded-defensive-code]
     !x || x.p;
 
-    !!u && u.p; // $ Alert
-    !!n && n.p; // $ Alert
-    !!o && o.p; // $ Alert
+    !!u && u.p; // $ Alert[js/unneeded-defensive-code]
+    !!n && n.p; // $ Alert[js/unneeded-defensive-code]
+    !!o && o.p; // $ Alert[js/unneeded-defensive-code]
     !!x && x.p;
 
-    u != undefined && u.p; // $ Alert
-    n != undefined && n.p; // $ Alert
-    o != undefined && o.p; // $ Alert
+    u != undefined && u.p; // $ Alert[js/unneeded-defensive-code]
+    n != undefined && n.p; // $ Alert[js/unneeded-defensive-code]
+    o != undefined && o.p; // $ Alert[js/unneeded-defensive-code]
     x != undefined && x.p;
 
-    u == undefined || u.p; // $ Alert
-    n == undefined || n.p; // $ Alert
-    o == undefined || o.p; // $ Alert
+    u == undefined || u.p; // $ Alert[js/unneeded-defensive-code]
+    n == undefined || n.p; // $ Alert[js/unneeded-defensive-code]
+    o == undefined || o.p; // $ Alert[js/unneeded-defensive-code]
     x == undefined || x.p;
 
-    u === undefined || u.p; // $ Alert
-    n === undefined || n.p; // $ Alert
-    o === undefined || o.p; // $ Alert
+    u === undefined || u.p; // $ Alert[js/unneeded-defensive-code]
+    n === undefined || n.p; // $ Alert[js/unneeded-defensive-code]
+    o === undefined || o.p; // $ Alert[js/unneeded-defensive-code]
     x === undefined || x.p;
 
-    if (u) { // $ Alert
+    if (u) { // $ Alert[js/unneeded-defensive-code]
         u.p;
     }
-    if (n) { // $ Alert
+    if (n) { // $ Alert[js/unneeded-defensive-code]
         n.p;
     }
-    if (o) { // $ Alert
+    if (o) { // $ Alert[js/unneeded-defensive-code]
         o.p;
     }
     if (x) {
         x.p;
     }
 
-    u? u():_; // $ Alert
-    n? n(): _; // $ Alert
-    o? o(): _; // $ Alert
+    u? u():_; // $ Alert[js/unneeded-defensive-code]
+    n? n(): _; // $ Alert[js/unneeded-defensive-code]
+    o? o(): _; // $ Alert[js/unneeded-defensive-code]
     x? x(): _;
 
-    if (u !== undefined) { // $ Alert
+    if (u !== undefined) { // $ Alert[js/unneeded-defensive-code]
         u.p;
     }
-    if (n !== undefined) { // $ Alert
+    if (n !== undefined) { // $ Alert[js/unneeded-defensive-code]
         n.p;
     }
-    if (o !== undefined) { // $ Alert
+    if (o !== undefined) { // $ Alert[js/unneeded-defensive-code]
         o.p;
     }
     if (x !== undefined) {
         x.p;
     }
 
-    if (u == undefined){} // $ Alert
-    if (n == undefined){} // $ Alert
-    if (o == undefined){} // $ Alert
+    if (u == undefined){} // $ Alert[js/unneeded-defensive-code]
+    if (n == undefined){} // $ Alert[js/unneeded-defensive-code]
+    if (o == undefined){} // $ Alert[js/unneeded-defensive-code]
     if (x == undefined){}
 
-    if (u != undefined){} // $ Alert
-    if (n != undefined){} // $ Alert
-    if (o != undefined){} // $ Alert
+    if (u != undefined){} // $ Alert[js/unneeded-defensive-code]
+    if (n != undefined){} // $ Alert[js/unneeded-defensive-code]
+    if (o != undefined){} // $ Alert[js/unneeded-defensive-code]
     if (x != undefined){}
 
-    if (typeof u === "undefined"){} // $ Alert
-    if (typeof n === "undefined"){} // $ Alert
-    if (typeof o === "undefined"){} // $ Alert
+    if (typeof u === "undefined"){} // $ Alert[js/unneeded-defensive-code]
+    if (typeof n === "undefined"){} // $ Alert[js/unneeded-defensive-code]
+    if (typeof o === "undefined"){} // $ Alert[js/unneeded-defensive-code]
     if (typeof x === "undefined"){}
 
     function f() { }
-    typeof f === "function" && f(); // $ Alert
-    typeof u === "function" && u(); // $ Alert
+    typeof f === "function" && f(); // $ Alert[js/unneeded-defensive-code]
+    typeof u === "function" && u(); // $ Alert[js/unneeded-defensive-code]
     typeof x === "function" && x();
 
     var empty_array = [];
@@ -111,9 +111,9 @@
     var _true = true;
     var _false = false;
 
-    empty_array && empty_array.pop(); // $ Alert
-    pseudo_empty_array && pseudo_empty_array.pop(); // $ Alert
-    non_empty_array && non_empty_array.pop(); // $ Alert
+    empty_array && empty_array.pop(); // $ Alert[js/unneeded-defensive-code]
+    pseudo_empty_array && pseudo_empty_array.pop(); // $ Alert[js/unneeded-defensive-code]
+    non_empty_array && non_empty_array.pop(); // $ Alert[js/unneeded-defensive-code]
     empty_string && empty_string.charAt(0);
     non_empty_string && non_empty_string.charAt(0);
     zero && zero();
@@ -121,23 +121,23 @@
     _true && _true();
     _false && _false();
 
-    (u !== undefined && u !== null) && u.p; // $ Alert
-    u !== undefined && u !== null && u.p; // $ Alert
+    (u !== undefined && u !== null) && u.p; // $ Alert[js/unneeded-defensive-code]
+    u !== undefined && u !== null && u.p; // $ Alert[js/unneeded-defensive-code]
 
-    u != undefined && u != null; // $ Alert
-    u == undefined || u == null; // $ Alert
-    u !== undefined && u !== null; // $ Alert
-    !(u === undefined) && !(u === null); // $ Alert
-    u === undefined || u === null; // $ Alert
-    !(u === undefined || u === null); // $ Alert
-    !(u === undefined) && u !== null; // $ Alert
+    u != undefined && u != null; // $ Alert[js/unneeded-defensive-code]
+    u == undefined || u == null; // $ Alert[js/unneeded-defensive-code]
+    u !== undefined && u !== null; // $ Alert[js/unneeded-defensive-code]
+    !(u === undefined) && !(u === null); // $ Alert[js/unneeded-defensive-code]
+    u === undefined || u === null; // $ Alert[js/unneeded-defensive-code]
+    !(u === undefined || u === null); // $ Alert[js/unneeded-defensive-code]
+    !(u === undefined) && u !== null; // $ Alert[js/unneeded-defensive-code]
     u !== undefined && n !== null;
-    u == undefined && u == null; // $ Alert
+    u == undefined && u == null; // $ Alert[js/unneeded-defensive-code]
     x == undefined && x == null;
 
-    x === undefined && x === null; // $ Alert
+    x === undefined && x === null; // $ Alert[js/unneeded-defensive-code]
     if (x === undefined) {
-        if (x === null) { // $ Alert
+        if (x === null) { // $ Alert[js/unneeded-defensive-code]
         }
     }
 
@@ -153,9 +153,9 @@
         }
     }
 
-    x != undefined && x != null; // $ Alert
+    x != undefined && x != null; // $ Alert[js/unneeded-defensive-code]
     if (x != undefined) {
-        if (x != null) { // $ Alert
+        if (x != null) { // $ Alert[js/unneeded-defensive-code]
         }
     }
 
@@ -174,8 +174,8 @@
 
 	u && (f(), u.p); // $ Alert[js/trivial-conditional]
 	u && (u.p, f()); // $ Alert[js/trivial-conditional] - technically not OK, but it seems like an unlikely pattern
-	u && !u.p; // $ Alert
-	u && !u(); // $ Alert
+	u && !u.p; // $ Alert[js/unneeded-defensive-code]
+	u && !u(); // $ Alert[js/unneeded-defensive-code]
 
 
     function hasCallbacks(success, error) {

javascript/ql/test/query-tests/Expressions/UnneededDefensiveProgramming/tst2.js

@@ -1,7 +1,7 @@
 (function(){
     var v;
     (function(){
-        if(typeof v === "undefined"){ // $ Alert
+        if(typeof v === "undefined"){ // $ Alert[js/unneeded-defensive-code]
             v = 42;
         }
         for(var v in x){