hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: Add missing override to ClassValue.hasAttribute

Browse Source 
I was considering if this was actually something different than
Value.hasAttribute, and the names were just accidentially the same. But after
looking at the definition for Value, I'm happy about marking this as an
override (I did not test whether it was neede though):

```codeql
class Value extends TObject {
    ...

    /** Holds if this value has the attribute `name` */
    predicate hasAttribute(string name) { this.(ObjectInternal).hasAttribute(name) }
```
This commit is contained in:
Rasmus Wriedt Larsen
2020-04-07 14:02:53 +02:00
parent 6685a5ed4d
commit 7af5f038ab
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
python/ql/src/semmle/python/objects/ObjectAPI.qll
View File

@@ -540,10 +540,10 @@ class ClassValue extends Value {
Value declaredAttribute(string name) { Types::declaredAttribute(this, name, result, _) }
/**
* Holds if this class has the attribute `name`, including
* attributes declared by super classes.
* Holds if this class has the attribute `name`, including attributes
* declared by super classes.
*/
predicate hasAttribute(string name) { this.getMro().declares(name) }
override predicate hasAttribute(string name) { this.getMro().declares(name) }
/**
* Holds if this class declares the attribute `name`,