hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-22 15:25:18 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: An empty models-as-data namespace / type is not 'dubious' in CPP.

Browse Source
This commit is contained in:
Geoffrey White
2024-06-04 08:55:49 +01:00
parent f479649727
commit 79e9198b20
2 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll
View File

@@ -330,10 +330,10 @@ module CsvValidation {
or
summaryModel(namespace, type, _, name, signature, ext, _, _, _, _) and pred = "summary"
|
not namespace.regexpMatch("[a-zA-Z0-9_\\.]+") and
not namespace.regexpMatch("[a-zA-Z0-9_\\.]*") and
result = "Dubious namespace \"" + namespace + "\" in " + pred + " model."
or
not type.regexpMatch("[a-zA-Z0-9_<>,\\+]+") and
not type.regexpMatch("[a-zA-Z0-9_<>,\\+]*") and
result = "Dubious type \"" + type + "\" in " + pred + " model."
or
not name.regexpMatch("[a-zA-Z0-9_<>,]*") and

6
cpp/ql/test/library-tests/dataflow/external-models/validatemodels.expected
View File

@@ -1,10 +1,4 @@
| Dubious namespace "" in sink model. |
| Dubious namespace "" in source model. |
| Dubious namespace "" in summary model. |
| Dubious namespace "boost::asio" in sink model. |
| Dubious namespace "boost::asio" in source model. |
| Dubious namespace "boost::asio" in summary model. |
| Dubious type "" in sink model. |
| Dubious type "" in source model. |
| Dubious type "" in summary model. |
| Invalid kind "remote-sink" in sink model. |