hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 10:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fixing queries based on suggestions/comments.

Browse Source 
TODO: Auto-formatting is still pending (need guidance on how to enable it on my environment). Thanks
This commit is contained in:
Raul Garcia (MSFT)
2020-07-29 17:14:37 -07:00
parent 83e9d052d9
commit 7923c480af
5 changed files with 25 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
csharp/ql/test/experimental/Security Features/Serialization/test0.cs
View File

@@ -10,9 +10,9 @@ using System.Collections.Generic;
namespace DataSetSerializationTest
{
public class DerivesFromDeprecatedType1 : XmlSerializer // bug
public class DerivesFromDeprecatedType1 : XmlSerializer // warning:DefiningDatasetRelatedType.ql
{
public DataSet MyDataSet { get; set; } // bug
public DataSet MyDataSet { get; set; } // bug:DefiningPotentiallyUnsafeXmlSerializer.ql
public DerivesFromDeprecatedType1()
{
@@ -56,9 +56,9 @@ namespace DataSetSerializationTest
*/
[Serializable()]
public class AttributeSerializer01 // bug
public class AttributeSerializer01 // warning:DefiningDatasetRelatedType.ql
{
private DataSet MyDataSet; // bug
private DataSet MyDataSet; // bug:DefiningPotentiallyUnsafeXmlSerializer.ql
AttributeSerializer01()
{
@@ -85,15 +85,15 @@ namespace DataSetSerializationTest
{
DataTable newTable = new DataTable();
System.Xml.XmlTextReader reader = new System.Xml.XmlTextReader(fs);
newTable.ReadXmlSchema(reader); //bug
newTable.ReadXmlSchema(reader); //bug:XmlDeserializationWithDataSet.ql
}
}
static void Main(string[] args)
{
XmlSerializer x = new XmlSerializer(typeof(DataSet)); // bug
XmlSerializer y = new XmlSerializer(typeof(AttributeSerializer01)); //bug
XmlSerializer x = new XmlSerializer(typeof(DataSet)); // bug:UnsafeTypeUsedDataContractSerializer.ql
XmlSerializer y = new XmlSerializer(typeof(AttributeSerializer01)); //bug:UnsafeTypeUsedDataContractSerializer.ql
Console.WriteLine("Hello World!");
}