hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-18 01:33:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Remove the problematic taint tracking rule. It seems like we get the flows from dataflow already now.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2020-09-14 09:26:41 +02:00
parent ff09104089
commit 78b24b76a0
1 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
cpp/ql/src/semmle/code/cpp/ir/dataflow/DefaultTaintTracking.qll
View File

@@ -257,15 +257,6 @@ private predicate instructionTaintStep(Instruction i1, Instruction i2) {
i2.(ChiInstruction).getPartial() = i1.(WriteSideEffectInstruction) and i2.(ChiInstruction).getPartial() = i1.(WriteSideEffectInstruction) and
not i2.isResultConflated() not i2.isResultConflated()
or or
// Flow from an element to an array or union that contains it.
i2.(ChiInstruction).getPartial() = i1 and
not i2.isResultConflated() and
exists(Type t | i2.getResultLanguageType().hasType(t, false) |
t instanceof Union
or
t instanceof ArrayType
)
or
exists(BinaryInstruction bin | exists(BinaryInstruction bin |
bin = i2 and bin = i2 and
predictableInstruction(i2.getAnOperand().getDef()) and predictableInstruction(i2.getAnOperand().getDef()) and