hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-22 15:25:18 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: getSourceDeclaration() and getASourceSupertype*() commute and this yields much better join-order.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2025-07-18 11:47:14 +02:00
parent 12732525b5
commit 7883124abd
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/ql/src/Likely Bugs/Collections/ContainsTypeMismatch.ql
View File

@@ -103,8 +103,8 @@ class MismatchedContainerAccess extends MethodCall {
|
this.getCallee()
.getDeclaringType()
.getASourceSupertype*()
.getSourceDeclaration()
.getASourceSupertype*()
.hasQualifiedName(package, type) and
this.getCallee().getParameter(i).getType() instanceof TypeObject
)
@@ -119,7 +119,7 @@ class MismatchedContainerAccess extends MethodCall {
containerAccess(package, type, p, this.getCallee().getSignature(), i)
|
t = this.getCallee().getDeclaringType() and
t.getASourceSupertype*().getSourceDeclaration() = g and
t.getSourceDeclaration().getASourceSupertype*() = g and
g.hasQualifiedName(package, type) and
indirectlyInstantiates(t, g, p, result)
)