hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 17:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix bad join-order in js/missing-this-qualifier

Browse Source
This commit is contained in:
erik-krogh
2023-01-09 16:06:26 +01:00
parent 5157d4df7b
commit 785c21f462
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
javascript/ql/src/Declarations/MissingThisQualifier.ql
View File

@@ -20,11 +20,17 @@ predicate maybeMissingThis(CallExpr call, MethodDeclaration intendedTarget, Glob
call.getCallee() = gv.getAnAccess() and
call.getCalleeName() = intendedTarget.getName() and
exists(MethodDefinition caller |
caller.getBody() = call.getContainer() and
caller.getBody() = getRelevantCallExprContainer(call) and
intendedTarget.getDeclaringClass() = caller.getDeclaringClass()
)
}
pragma[noinline]
private StmtContainer getRelevantCallExprContainer(CallExpr c) {
result = c.getContainer() and
c.getCallee() = any(GlobalVariable v).getAnAccess()
}
from CallExpr call, MethodDeclaration intendedTarget, GlobalVariable gv
where
maybeMissingThis(call, intendedTarget, gv) and
@@ -46,7 +52,7 @@ where
exists(Variable decl |
decl.getName() = gv.getName() and
decl.isNamespaceExport() and
call.getContainer().getEnclosingContainer*() instanceof NamespaceDeclaration
getRelevantCallExprContainer(call).getEnclosingContainer*() instanceof NamespaceDeclaration
)
or
// call to global function with additional arguments