hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-23 07:45:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

JavaScript: Be more lenient about namespace matching.

Browse Source
This commit is contained in:
Max Schaefer
2019-03-01 11:50:25 +00:00
parent 41d83d5b7d
commit 77e59f1a47
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
javascript/ql/src/semmle/javascript/frameworks/SocketIO.qll
View File

@@ -372,7 +372,7 @@ module SocketIOClient {
)
}
/** Gets the path of the namespace this socket belongs to. */
/** Gets the path of the namespace this socket belongs to, if it can be determined. */
string getNamespacePath() {
// the path name of the specified URL
exists(string url, string pathRegex |
@@ -395,7 +395,9 @@ module SocketIOClient {
SocketIO::ServerObject getATargetServer() {
exists(NPMPackage pkg |
result.getOrigin().getFile() = pkg.getAFile() and
this.getFile() = pkg.getAFile() and
this.getFile() = pkg.getAFile()
|
not exists(getNamespacePath()) or
exists(result.getNamespace(getNamespacePath()))
)
}
@@ -403,6 +405,10 @@ module SocketIOClient {
/** Gets a namespace this socket may be communicating with. */
SocketIO::NamespaceObject getATargetNamespace() {
result = getATargetServer().getNamespace(getNamespacePath())
or
// if the namespace of this socket cannot be determined, overapproximate
not exists(getNamespacePath()) and
result = getATargetServer().getNamespace(_)
}
/** Gets a server-side socket this client-side socket may be communicating with. */
@@ -473,7 +479,7 @@ module SocketIOClient {
SocketNode getSocket() { result = base }
/**
* Gets the path of the namespace to which data is sent.
* Gets the path of the namespace to which data is sent, if it can be determined.
*/
string getNamespacePath() { result = base.getNamespacePath() }