hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 17:25:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #20095 from jcogs33/jcogs33/java/finalizers-on-exit-and-garbage-collection

Browse Source 
Java: Add `previous-id` and adjust tags for `java/garbage-collection` and `java/run-finalizers-on-exit`
This commit is contained in:
Jami
2025-08-21 08:10:36 -04:00
committed by GitHub
parent f1c6064f4e bca2c2da54
commit 771d7cb171
4 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
java/ql/integration-tests/java/query-suite/java-code-quality-extended.qls.expected
View File

@@ -80,6 +80,7 @@ ql/java/ql/src/Violations of Best Practice/Naming Conventions/LocalShadowsFieldC
ql/java/ql/src/Violations of Best Practice/Naming Conventions/SameNameAsSuper.ql
ql/java/ql/src/Violations of Best Practice/Records/IgnoredSerializationMembersOfRecordClass.ql
ql/java/ql/src/Violations of Best Practice/SpecialCharactersInLiterals/NonExplicitControlAndWhitespaceCharsInLiterals.ql
ql/java/ql/src/Violations of Best Practice/Undesirable Calls/CallsToRunFinalizersOnExit.ql
ql/java/ql/src/Violations of Best Practice/Undesirable Calls/CallsToStringToString.ql
ql/java/ql/src/Violations of Best Practice/Undesirable Calls/DefaultToString.ql
ql/java/ql/src/Violations of Best Practice/Undesirable Calls/DoNotCallFinalize.ql

7
java/ql/src/Violations of Best Practice/Undesirable Calls/CallsToRunFinalizersOnExit.ql
View File

@@ -7,8 +7,11 @@
* @problem.severity error
* @precision medium
* @id java/run-finalizers-on-exit
* @tags reliability
* maintainability
* @previous-id java/do-not-use-finalizers
* @tags quality
* reliability
* correctness
* performance
*/
import java

6
java/ql/src/Violations of Best Practice/Undesirable Calls/GarbageCollection.ql
View File

@@ -6,8 +6,10 @@
* @problem.severity recommendation
* @precision low
* @id java/garbage-collection
* @tags reliability
* maintainability
* @previous-id java/do-not-use-finalizers
* @tags quality
* reliability
* correctness
*/
import java

5
java/ql/src/change-notes/2025-07-19-adjust-tags.md Normal file
View File

@@ -0,0 +1,5 @@
---
category: queryMetadata
---
* The tag `maintainability` has been removed from `java/run-finalizers-on-exit` and the tags `quality`, `correctness`, and `performance` have been added.
* The tag `maintainability` has been removed from `java/garbage-collection` and the tags `quality` and `correctness` have been added.