hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Address review.

Browse Source
This commit is contained in:
Cornelius Riemenschneider
2020-12-01 19:08:49 +01:00
parent 5b1ab86ac6
commit 7700e87cca
3 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/ql/test/library-tests/dataflow/dataflow-tests/clang.cpp
View File

@@ -19,7 +19,7 @@ void following_pointers(
sink(sourceArray1[0]); // no flow
sink(*sourceArray1); // no flow
sink(&sourceArray1); // $ ast // [should probably taint only]
sink(&sourceArray1); // $ ast // [should probably be taint only]
sink(sourceStruct1.m1); // no flow
sink(sourceStruct1_ptr->m1); // no flow

12
cpp/ql/test/library-tests/dataflow/taint-tests/localTaint.expected
View File

@@ -1448,8 +1448,6 @@
| map.cpp:304:15:304:19 | call to begin | map.cpp:306:9:306:10 | i2 | |
| map.cpp:304:15:304:19 | call to begin | map.cpp:307:8:307:9 | i2 | |
| map.cpp:304:15:304:19 | call to begin | map.cpp:308:8:308:9 | i2 | |
| map.cpp:304:15:304:19 | call to begin | map.cpp:313:8:313:9 | i2 | |
| map.cpp:304:15:304:19 | call to begin | map.cpp:314:8:314:9 | i2 | |
| map.cpp:304:30:304:31 | m2 | map.cpp:304:33:304:35 | call to end | TAINT |
| map.cpp:304:30:304:31 | ref arg m2 | map.cpp:304:30:304:31 | m2 | |
| map.cpp:304:30:304:31 | ref arg m2 | map.cpp:334:7:334:8 | m2 | |
@@ -1462,8 +1460,6 @@
| map.cpp:304:40:304:41 | ref arg i2 | map.cpp:306:9:306:10 | i2 | |
| map.cpp:304:40:304:41 | ref arg i2 | map.cpp:307:8:307:9 | i2 | |
| map.cpp:304:40:304:41 | ref arg i2 | map.cpp:308:8:308:9 | i2 | |
| map.cpp:304:40:304:41 | ref arg i2 | map.cpp:313:8:313:9 | i2 | |
| map.cpp:304:40:304:41 | ref arg i2 | map.cpp:314:8:314:9 | i2 | |
| map.cpp:306:8:306:8 | call to operator* | map.cpp:306:8:306:10 | call to pair | TAINT |
| map.cpp:306:9:306:10 | i2 | map.cpp:306:8:306:8 | call to operator* | TAINT |
| map.cpp:307:8:307:9 | i2 | map.cpp:307:10:307:10 | call to operator-> | TAINT |
@@ -1475,6 +1471,8 @@
| map.cpp:310:15:310:19 | call to begin | map.cpp:310:24:310:25 | i3 | |
| map.cpp:310:15:310:19 | call to begin | map.cpp:310:40:310:41 | i3 | |
| map.cpp:310:15:310:19 | call to begin | map.cpp:312:9:312:10 | i3 | |
| map.cpp:310:15:310:19 | call to begin | map.cpp:313:8:313:9 | i3 | |
| map.cpp:310:15:310:19 | call to begin | map.cpp:314:8:314:9 | i3 | |
| map.cpp:310:30:310:31 | m3 | map.cpp:310:33:310:35 | call to end | TAINT |
| map.cpp:310:30:310:31 | ref arg m3 | map.cpp:310:30:310:31 | m3 | |
| map.cpp:310:30:310:31 | ref arg m3 | map.cpp:438:1:438:1 | m3 | |
@@ -1482,10 +1480,12 @@
| map.cpp:310:40:310:41 | ref arg i3 | map.cpp:310:24:310:25 | i3 | |
| map.cpp:310:40:310:41 | ref arg i3 | map.cpp:310:40:310:41 | i3 | |
| map.cpp:310:40:310:41 | ref arg i3 | map.cpp:312:9:312:10 | i3 | |
| map.cpp:310:40:310:41 | ref arg i3 | map.cpp:313:8:313:9 | i3 | |
| map.cpp:310:40:310:41 | ref arg i3 | map.cpp:314:8:314:9 | i3 | |
| map.cpp:312:8:312:8 | call to operator* | map.cpp:312:8:312:10 | call to pair | TAINT |
| map.cpp:312:9:312:10 | i3 | map.cpp:312:8:312:8 | call to operator* | TAINT |
| map.cpp:313:8:313:9 | i2 | map.cpp:313:10:313:10 | call to operator-> | TAINT |
| map.cpp:314:8:314:9 | i2 | map.cpp:314:10:314:10 | call to operator-> | TAINT |
| map.cpp:313:8:313:9 | i3 | map.cpp:313:10:313:10 | call to operator-> | TAINT |
| map.cpp:314:8:314:9 | i3 | map.cpp:314:10:314:10 | call to operator-> | TAINT |
| map.cpp:318:37:318:39 | call to unordered_map | map.cpp:319:7:319:9 | m10 | |
| map.cpp:318:37:318:39 | call to unordered_map | map.cpp:323:7:323:9 | m10 | |
| map.cpp:318:37:318:39 | call to unordered_map | map.cpp:438:1:438:1 | m10 | |

4
cpp/ql/test/library-tests/dataflow/taint-tests/map.cpp
View File

@@ -310,8 +310,8 @@ void test_unordered_map()
for (i3 = m3.begin(); i3 != m3.end(); i3++)
{
sink(*i3); // $ MISSING: ast,ir
sink(i2->first); // $ ir MISSING: ast
sink(i2->second); // $ SPURIOUS: ir
sink(i3->first); // $ MISSING: ast,ir
sink(i3->second); // clean
}
// array-like access