hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 03:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fixup JaxRs.ql to cope with stubbed MediaType file

Browse Source 
In a real-world situation this type would be defined in an imported jar, but since here it is defined in a stub the getADeclaredContentType routine can see it is defined as an empty string in the stubbed implementation. Filter these out so the test more closely resembles the real situation.
This commit is contained in:
Chris Smowton
2021-06-28 19:20:16 +01:00
parent 8eaffaff35
commit 768a8e78dd
1 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
java/ql/test/library-tests/frameworks/JaxWs/JaxRs.ql
View File

@@ -24,8 +24,16 @@ class JaxRsTest extends InlineExpectationsTest {
resourceMethod.getLocation() = location and
element = resourceMethod.toString() and
if exists(resourceMethod.getProducesAnnotation())
then value = resourceMethod.getProducesAnnotation().getADeclaredContentType()
else value = ""
then
value = resourceMethod.getProducesAnnotation().getADeclaredContentType() and
value != ""
else
// Filter out empty strings that stem from using stubs.
// If we built the test against the real JAR then the field
// access against e.g. MediaType.APPLICATION_JSON wouldn't
// be a CompileTimeConstantExpr at all, whereas in the stubs
// it is and is defined empty.
value = ""
)
or
tag = "RootResourceClass" and
@@ -135,7 +143,13 @@ class JaxRsTest extends InlineExpectationsTest {
exists(JaxRSProducesAnnotation producesAnnotation |
producesAnnotation.getLocation() = location and
element = producesAnnotation.toString() and
value = producesAnnotation.getADeclaredContentType()
value = producesAnnotation.getADeclaredContentType() and
value != ""
// Filter out empty strings that stem from using stubs.
// If we built the test against the real JAR then the field
// access against e.g. MediaType.APPLICATION_JSON wouldn't
// be a CompileTimeConstantExpr at all, whereas in the stubs
// it is and is defined empty.
)
or
tag = "ConsumesAnnotation" and