hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 02:35:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1326 from jbj/addressConstantVariable-isConstexpr

Browse Source 
C++: Use isConstexpr instead of workaround in AddressConstantExpr
This commit is contained in:
Robert Marsh
2019-05-16 15:18:56 -07:00
committed by GitHub
parent 5f77ac4cf5 f38253da89
commit 762c977be7
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cpp/ql/src/semmle/code/cpp/internal/AddressConstantExpression.qll
View File

@@ -1,5 +1,4 @@
private import cpp
private import semmle.code.cpp.dataflow.EscapesTree
predicate addressConstantExpression(Expr e) {
constantAddressPointer(e)
@@ -14,10 +13,7 @@ predicate addressConstantExpression(Expr e) {
/** Holds if `v` is a constexpr variable initialized to a constant address. */
private predicate addressConstantVariable(Variable v) {
addressConstantExpression(v.getInitializer().getExpr().getFullyConverted()) and
// Here we should also require that `v` is constexpr, but we don't have that
// information in the db. See CPP-314. Instead, we require that the variable
// is never defined except in its initializer.
forall(Expr def | definition(v, def) | def = any(Initializer init).getExpr())
v.isConstexpr()
}
/**