hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-20 18:56:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

C#/Java/Ruby/Swift: Address review comments.

Browse Source
This commit is contained in:
Michael Nebel
2022-08-18 14:16:46 +02:00
parent f728ddf823
commit 761ed283b6
12 changed files with 28 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/src/utils/model-generator/internal/CaptureModels.qll
View File

@@ -50,8 +50,6 @@ private string asSummaryModel(TargetApi api, string input, string output, string
string asNegativeSummaryModel(TargetApi api) { result = asPartialNegativeModel(api) + "generated" }
predicate partialNegativeModel = asPartialNegativeModel/1;
/**
* Gets the value summary model for `api` with `input` and `output`.
*/

8
java/ql/src/utils/model-generator/internal/CaptureSummaryFlow.qll
View File

@@ -74,13 +74,9 @@ string captureFlow(TargetApi api) {
/**
* Gets the negative summary for `api`, if any.
* A negative summary is generated, if there does not exist any positive flow that
* shares the same summary prefix - otherwise these models will be indistinguishable.
* A negative summary is generated, if there does not exist any positive flow.
*/
string captureNoFlow(TargetApi api) {
not exists(TargetApi other, string flow |
flow = captureFlow(other) and
partialNegativeModel(other) = partialNegativeModel(api)
) and
not exists(captureFlow(api)) and
result = asNegativeSummaryModel(api)
}