hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 17:23:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

Ruby: Block flow from LHS of && expressions

Browse Source 
The only values that can flow from the LHS of an && expression are
`false` and `nil`, neither of which seem relevant for any of our
queries.
This commit is contained in:
Harry Maclean
2024-01-30 08:53:32 +00:00
parent aeae208dc3
commit 75b13da4e4
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowPrivate.qll
View File

@@ -220,8 +220,10 @@ module LocalFlow {
or or
nodeTo.asExpr() = nodeTo.asExpr() =
any(CfgNodes::ExprNodes::BinaryOperationCfgNode op | any(CfgNodes::ExprNodes::BinaryOperationCfgNode op |
op.getExpr() instanceof BinaryLogicalOperation and op.getExpr() instanceof LogicalOrExpr and
nodeFrom.asExpr() = op.getAnOperand() nodeFrom.asExpr() = op.getAnOperand()
or
op.getExpr() instanceof LogicalAndExpr and nodeFrom.asExpr() = op.getRightOperand()
) )
or or
nodeTo.(ParameterNodeImpl).getParameter() = nodeTo.(ParameterNodeImpl).getParameter() =