hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 20:25:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

false negative testing - before rewrite for variable dataflow

Browse Source
This commit is contained in:
Jami Cogswell
2022-10-04 11:59:20 -04:00
parent 7d94590d79
commit 75794ec7a7
2 changed files with 34 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
java/ql/test/query-tests/security/CWE-326/InsufficientKeySizeTest.java
View File

@@ -3,7 +3,7 @@ import java.security.spec.ECGenParameterSpec;
import javax.crypto.KeyGenerator;
public class InsufficientKeySizeTest {
public void CryptoMethod() throws java.security.NoSuchAlgorithmException, java.security.InvalidAlgorithmParameterException {
public void cryptoMethod() throws java.security.NoSuchAlgorithmException, java.security.InvalidAlgorithmParameterException {
KeyGenerator keyGen1 = KeyGenerator.getInstance("AES");
// BAD: Key size is less than 128
keyGen1.init(64); // $ hasInsufficientKeySize
@@ -89,5 +89,26 @@ public class InsufficientKeySizeTest {
KeyPairGenerator keyPairGen17 = KeyPairGenerator.getInstance("DH");
// GOOD: Key size is no less than 2048
keyPairGen17.initialize(2048); // Safe
// FN: Test with variables as numbers
final int size1 = 64;
KeyGenerator keyGen3 = KeyGenerator.getInstance("AES");
// BAD: Key size is less than 128
keyGen3.init(size1); // $ hasInsufficientKeySize
int size2 = 1024;
KeyPairGenerator keyPairGen18 = KeyPairGenerator.getInstance("RSA");
// BAD: Key size is less than 2048
keyPairGen18.initialize(size2); // $ hasInsufficientKeySize
int keysize = 64;
test(keysize);
}
public void test(int keySize) throws java.security.NoSuchAlgorithmException, java.security.InvalidAlgorithmParameterException {
KeyGenerator keyGen4 = KeyGenerator.getInstance("AES");
// BAD: Key size is less than 128
keyGen4.init(keySize); // $ hasInsufficientKeySize
}
}